Sticky header: ensure language button only shows when multiple languages
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	bwang
	Jan 6 2022, 4:26 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Go to a page with only a single language
Scroll down the page until the sticky header appears

What happens?:
Language switcher appears with "0 languages"

What should have happened instead?:
No language switcher appears

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
https://phabricator.wikimedia.org/F34909440

See https://phabricator.wikimedia.org/T297362 for related task

AC

When an article is not available in any other languages, do not display the language button
Language button doesn't show when language in header is not enabled (i.e. Wikicommons)

Details

	Subject	Repo	Branch	Lines +/-
	Ensure sticky header language button only shows when there are multiple languages and when ULS is enabled	mediawiki/skins/Vector	master	+9 -7

Customize query in gerrit

Related Objects

Mentioned Here: T297362: Sticky header: ensure correct language presentation on multi-language wikis

Event Timeline

bwang created this task.Jan 6 2022, 4:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2022, 4:26 PM

ovasileva triaged this task as High priority.Jan 6 2022, 6:06 PM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs Analysis to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 6 2022, 6:17 PM

LGoto set the point value for this task to 2.Jan 6 2022, 6:17 PM

LGoto moved this task from Incoming to Sticky header on the Desktop Improvements (Vector 2022) board.

bwang claimed this task.Jan 6 2022, 9:13 PM

Change 752003 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure sticky header language button only shows when there are multiple languages and the ULS is enabled

https://gerrit.wikimedia.org/r/752003

gerritbot added a project: Patch-For-Review.Jan 6 2022, 9:49 PM

bwang removed bwang as the assignee of this task.Jan 6 2022, 10:05 PM

bwang moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

bwang updated the task description. (Show Details)Jan 6 2022, 10:08 PM

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 7 2022, 1:14 AM

bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 7 2022, 8:43 PM

Test wiki created on Patch demo by BWang (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/4e0458c5db/w/

Test wiki on Patch demo by BWang (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/4e0458c5db/w/~~

Change 752003 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure sticky header language button only shows when there are multiple languages and when ULS is enabled

https://gerrit.wikimedia.org/r/752003

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2022, 12:10 AM

Jdlrobson assigned this task to Edtadros.Jan 8 2022, 12:20 AM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

IKhitron subscribed.Jan 12 2022, 12:47 AM

Has been in production for a month.

Verified in production. Resolving.

QA:

Go to a page with only a single language: https://en.wikipedia.org/wiki/Cardiff_City_F.C._2%E2%80%931_Leeds_United_F.C._(2002)
Scroll down the page until the sticky header appears
Language button should not appear within the sticky header

Screen Shot 2022-02-17 at 7.36.25 PM.png (483×1 px, 162 KB)

	F34954689: Screen Shot 2022-02-17 at 7.36.25 PM.png
	Feb 17 2022, 6:37 PM

Sticky header: ensure language button only shows when multiple languagesClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

AC

Details

Related Objects

Event Timeline

Sticky header: ensure language button only shows when multiple languages
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions