Maniphest T298712

Remove ISP and ASN from the popup [S]
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Jan 6 2022, 5:09 PM

Tags

Referenced Files

	F34914498: no_isp_asn.png
	Jan 11 2022, 3:40 PM

Subscribers

Description

This was asked for in T286662, but separated out from that work.

The ISP and ASN should be removed from the popup, but not from the infobox.

Relevant file: ext.ipinfo/popup/widget.js

Details

	Subject	Repo	Branch	Lines +/-
	Remove ISP and ASN from PopUp	mediawiki/extensions/IPInfo	master	+0 -2

Customize query in gerrit

Related Objects

Mentioned Here: rEIPIf914329d87a6: Localisation updates from https://translatewiki.net.
T286662: Display block and contribs info in popup and infobox [S]

Event Timeline

Tchanders created this task.Jan 6 2022, 5:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2022, 5:09 PM

Tchanders moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jan 6 2022, 5:24 PM

Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

• AGueyte claimed this task.Jan 6 2022, 9:38 PM

• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 752001 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/IPInfo@master] Remove ISP and ASN from PopUp

https://gerrit.wikimedia.org/r/752001

gerritbot added a project: Patch-For-Review.Jan 6 2022, 9:45 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jan 7 2022, 2:48 AM

Change 752001 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Remove ISP and ASN from PopUp

https://gerrit.wikimedia.org/r/752001

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 7 2022, 5:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2022, 5:10 AM

• wikitrent moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Jan 7 2022, 2:16 PM

I see the ISP and ASN is no longer listed in the popup (I tried Recent Changes, revision history and Special:Log):

no_isp_asn.png (246×330 px, 17 KB)

All we have is:

Location
Organization
Active Blocks
Contributions

They are still present on the Special:Contributions accordion.

Test environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (f914329) 07:23, 11 January 2022.

• Niharika closed this task as Resolved.Feb 17 2022, 1:47 AM

• Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM