For contractors only:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| admins: add jvargas to ldap_only_admins, added to wmf group | operations/puppet | production | +4 -0 |
to SRE on clinic duty: could not verify user, no defined manager triggers bug in check script?
Username: JVargas
Verified Email: 20220106184544
Traceback (most recent call last):
File "/usr/local/sbin/check_user", line 182, in <module>
raise SystemExit(main())
File "/usr/local/sbin/check_user", line 167, in main
[r['value'] for r in user['relations'] if r['type'] == 'manager']
KeyError: 'relations'Hi @Dzahn - Just saw the error on the request, and in case it's helpful, my manager is Lisa Gruwell. Let me know if there's anything else I can provide. Thanks!
@JVargas Hello, don't worry about that part. it was a little bug in software but it has since been fixed.
Thanks for adding that Lisa is a your manager. I'll get this going!
@JVargas You have been added to the requested group. This gives you a bunch of new access. You can see a list here: https://wikitech.wikimedia.org/wiki/SRE/LDAP/Groups#wmf_group
There will be a few more automatic updates here when we have to add you to the right place in a code repository but you can safely ignore that. Things should work now and this is basically resolved.
Change 752725 had a related patch set uploaded (by Dzahn; author: Dzahn):
[operations/puppet@production] admins: add jvargas to ldap_only_admins, added to wmf group
Change 752725 merged by Cathal Mooney:
[operations/puppet@production] admins: add jvargas to ldap_only_admins, added to wmf group
Thanks Daniel for all the work on this, patch is now merged.
@JVargas is all good from your point of view? Otherwise I will proceed to close this request. thanks.
IIUC this isn't complete yet per items in https://wikitech.wikimedia.org/wiki/SRE/Clinic_Duty/Access_requests#LDAP_access
@cmooney Cool, thanks for closing this!
What Andre meant here above is that we are also supposed to add users to the Phabricator group called WMF-NDA when we add people into the LDAP group wmf.
I just did that here: https://phabricator.wikimedia.org/project/members/61/
done