Page MenuHomePhabricator
Create Task
Maniphest T298722

Remove prefix search from Special:ListFiles/NewFiles
Closed, ResolvedPublic
Actions

Description

This feature is currently disabled for WMF production wikis which run in MiserMode.

It currently relies on the database LOWER() function, which may notif the database field has the wrong collation.
The use of Title::newFromText may apply normalization which are not useful for prefix/like searches as done here.

This should be done by a search backend, which can do that with better performance.

Details

SubjectRepoBranchLines +/-
Remove prefix search from Special:ListFiles/NewFilesmediawiki/coremaster+3 -64
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jan 6 2022, 7:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2022, 7:26 PM
gerritbot added a comment.Jan 6 2022, 7:27 PM

Change 747945 had a related patch set uploaded (by Krinkle; author: Umherirrender):

[mediawiki/core@master] Remove prefix search from Special:ListFiles/NewFiles

https://gerrit.wikimedia.org/r/747945

gerritbot added a project: Patch-For-Review.Jan 6 2022, 7:27 PM
Krinkle added a project: MediaWiki-File-management.Jan 6 2022, 7:27 PM
Maintenance_bot added a project: Commons.Jan 6 2022, 7:46 PM
Krinkle removed a project: Performance-Team.Jan 10 2022, 7:49 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptJan 10 2022, 7:49 PM
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.Jan 10 2022, 7:50 PM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Jan 18 2022, 10:03 PM
Krinkle removed a project: MediaViewer.
Krinkle moved this task from Untriaged to Misc bookmarks on the Wikimedia-Performance-publish board.
gerritbot added a comment.Jan 19 2022, 5:16 PM

Change 747945 merged by jenkins-bot:

[mediawiki/core@master] Remove prefix search from Special:ListFiles/NewFiles

https://gerrit.wikimedia.org/r/747945

Umherirrender closed this task as Resolved.Jan 19 2022, 5:19 PM
Umherirrender triaged this task as Medium priority.
Umherirrender removed a project: Patch-For-Review.
Umherirrender mentioned this in T34207: Special:Listfiles doesn't find anything when search term contains non-ascii characters.Jan 19 2022, 5:23 PM
Umherirrender mentioned this in T29300: Searching on Special:Listfiles fails on MySQL due to invalid "LOWER(img_name)" query for binary field.
Umherirrender added a comment.Jan 19 2022, 5:51 PM

[Crosslinking: T286792]

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 19 2022, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL