Page MenuHomePhabricator

After activation login with github action a lot of tests fails
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce:
https://github.com/xqt/pwb/runs/4737554636?check_suite_focus=true for example

What happens?:

======================================================================
FAIL: test_dry (tests.deletionbot_tests.TestDeletionBot)
Test dry run of bot.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/pwb/pwb/tests/deletionbot_tests.py", line 105, in test_dry
    delete.main('-page:Main Page', '-always', '-summary:foo')
  File "/home/runner/work/pwb/pwb/scripts/delete.py", line 291, in main
    bot.run()
  File "/home/runner/work/pwb/pwb/pywikibot/bot.py", line 1596, in run
    self.treat(page)
  File "/home/runner/work/pwb/pwb/pywikibot/bot.py", line 1851, in treat
    self.treat_page()
  File "/home/runner/work/pwb/pwb/scripts/delete.py", line 212, in treat_page
    self.current_page.site.login()
  File "/home/runner/work/pwb/pwb/pywikibot/site/_apisite.py", line 390, in login
    assert self.userinfo['name'] == self.username(), \
AssertionError: 20.106.97.78 != ***

What should have happened instead?:

  1. We could decrease parallel actions to 1. In result none or only a few action tasks will fail, see https://github.com/xqt/pwb/actions/runs/1663138832 for example but the test time increases from 1 hour to 4 hours then.
  2. We could remove the assert check in APISite.login() and use not logged in status. Most tests will just skip then.
  3. The reason might be login/logout checks done in parallel task. We should make a separate action for this

Software version:
Pywikibot 7.0.0

Event Timeline

Xqt triaged this task as High priority.Jan 7 2022, 10:42 AM
Xqt added a subscriber: Mpaa.

Change 752147 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Don't assert login result

https://gerrit.wikimedia.org/r/752147

Change 752147 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Don't assert login result

https://gerrit.wikimedia.org/r/752147

Change 752704 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Add login_tests-ci.yml

https://gerrit.wikimedia.org/r/752704

Change 752704 merged by Xqt:

[pywikibot/core@master] [tests] Add login_tests-ci.yml

https://gerrit.wikimedia.org/r/752704

Change 752715 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] skip site_login_logout tests if environment var is not set

https://gerrit.wikimedia.org/r/752715

Change 752715 merged by jenkins-bot:

[pywikibot/core@master] [tests] skip site_login_logout tests if environment var is not set

https://gerrit.wikimedia.org/r/752715

Xqt claimed this task.