Page MenuHomePhabricator

Create separate user right for editing json files in gadget namespace
Closed, ResolvedPublic

Description

Now that T198758 has been implemented, admins are able to edit gadget json pages, with MediaWikiGadgetDefinitionRepo. However, GadgetDefinitionNamespaceRepo uses a single gadgets-edit right for all files in the namespace.

Ideally, there should be a different user right for json, so that it can be given to admins rather than just interface-admins.

Event Timeline

Change 826956 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/Gadgets@master] Create separate user right for editing gadget JSON pages

https://gerrit.wikimedia.org/r/826956

Considering that editsitejson right already exists, I think we actually don't need a separate one for gadget json. But then, it would also not make sense for the new namespace repo to have the gadgets-edit right as its similarly redundant to editsitecss/editsitejs.

This would also resole T229735, which has been a major drama point in the past.

Change 826956 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Remove gadgets-edit right, use core editsite{css,js,json} rights instead

https://gerrit.wikimedia.org/r/826956