| • alexhollender_WMF | |
| Jan 8 2022, 6:27 PM |
| F34954684: Screen Shot 2022-02-17 at 7.33.32 PM.png | |
| Feb 17 2022, 6:34 PM |
| F34945997: Screen Shot 2022-02-08 at 3.34.08 PM.png | |
| Feb 8 2022, 11:43 PM |
| F34945998: Screen Shot 2022-02-08 at 3.33.59 PM.png | |
| Feb 8 2022, 11:43 PM |
| F34946003: Screen Recording 2022-02-08 at 3.40.06 PM.mov.gif | |
| Feb 8 2022, 11:43 PM |
| F34911520: image.png | |
| Jan 8 2022, 6:27 PM |
| F34911523: Screen Shot 2022-01-08 at 1.23.14 PM.png | |
| Jan 8 2022, 6:27 PM |
Currently the ULS is about 22px below the ULS button. It should be closer to the button. The user menu + user menu button should be used as a reference for the correct spacing.
| too much space | correct |
|---|---|
 |  |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T298835#7695611 this is a pass per T298835#7696927 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T283505 [EPIC] Fixed "sticky" site header | |||
| Resolved | ovasileva | T298835 [Sticky header] Adjust position of ULS menu |
Change 755474 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Ensure sticky header ULS menu appears in default location right underneath the button
Change 755474 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Ensure sticky header ULS menu appears in default location right underneath the button
Status: ❓
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
❓ AC1: Currently the ULS is about 22px below the ULS button. It should be closer to the button. The user menu + user menu button should be used as a reference for the correct spacing.
@alexhollender_WMF, There is a slightly bigger gap between the blue outline on the ULS and the menu as compared to the user menu button and the user menu. Since the ULS doesn't stay outlined when you click it, I used the super scientific method of clicking it rapidly to see if there was a gap. Is this slightly larger gap a pass? Also is the lack of outline when the ULS is clicked an issue?
@Edtadros thanks for the detailed review here, we can consider this a pass.
