Page MenuHomePhabricator
Create Task
Maniphest T298836

[Sticky header] hide sticky header on browser windows below 1000px wide
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Description

Based on space requirements/limitations we sketched out in T289641, the sticky header should hide when the browser window is 1000px wide (and below).

Notes

In the future we should revisit this and figure out a more responsive design for the sticky header so that we don't have to hide it.

QA steps

  • Navigate to (TK - beta cluster or patchdemo link) a page in modern Vector as a logged in user.
  • Scroll down to see sticky header and resize browser window - below 1000px sticky header disappears, above 1000px sticky header appears.

QA Results - Beta

ACStatusDetails
1✅T298836#7687659

QA Results - Prod

ACStatusDetails
1✅T298836#7702774

Details

SubjectRepoBranchLines +/-
Hide sticky header below 1000px port widthmediawiki/skins/Vectormaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alexhollender_WMF created this task.Jan 8 2022, 6:56 PM
ovasileva triaged this task as Medium priority.Jan 10 2022, 10:11 AM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 11 2022, 6:16 PM
LGoto moved this task from Incoming to Sticky header on the Desktop Improvements (Vector 2022) board.Jan 11 2022, 6:30 PM
LGoto set the point value for this task to 2.
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
• alexhollender_WMF renamed this task from [Sticky header] hide sticky header on browser windows below 1200px wide to [Sticky header] hide sticky header on browser windows below 1000px wide.Jan 28 2022, 3:07 AM
• alexhollender_WMF updated the task description. (Show Details)
• alexhollender_WMF mentioned this in T300077: [Table of Contents] Offset the top position of the table of contents to the height of the sticky header only when the sticky header is/will be shown.
cjming claimed this task.Feb 3 2022, 8:39 PM
cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Feb 3 2022, 8:55 PM

Change 759592 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Hide sticky header below 1000px port width

https://gerrit.wikimedia.org/r/759592

gerritbot added a project: Patch-For-Review.Feb 3 2022, 8:55 PM
cjming removed cjming as the assignee of this task.Feb 3 2022, 8:58 PM
cjming updated the task description. (Show Details)
cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming subscribed.
Jdlrobson assigned this task to Edtadros.Feb 3 2022, 10:05 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Feb 3 2022, 10:20 PM

Change 759592 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Hide sticky header below 1000px port width

https://gerrit.wikimedia.org/r/759592

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 3 2022, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 3 2022, 11:10 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 7 2022, 3:30 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Navigate to (TK - beta cluster or patchdemo link) a page in modern Vector as a logged in user. Scroll down to see sticky header and resize browser window - below 1000px sticky header disappears, above 1000px sticky header appears.

Screen Recording 2022-02-06 at 7.26.40 PM.mov.gif (382×1 px, 1 MB)

Edtadros updated the task description. (Show Details)Feb 7 2022, 3:31 AM
Edtadros updated the task description. (Show Details)Feb 10 2022, 11:30 PM
Edtadros reassigned this task from Edtadros to ovasileva.Feb 10 2022, 11:38 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Navigate to a page in modern Vector as a logged in user. Scroll down to see sticky header and resize browser window - below 1000px sticky header disappears, above 1000px sticky header appears.

Screen Recording 2022-02-10 at 3.36.03 PM.mov.gif (364×1 px, 2 MB)

Edtadros updated the task description. (Show Details)Feb 10 2022, 11:38 PM
ovasileva closed this task as Resolved.Feb 11 2022, 12:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL