Page MenuHomePhabricator

Hide new Vector via configuration rather than hardcoded in Vector skin
Closed, ResolvedPublic2 Estimated Story Points

Description

Currently, the new Vector skin is marked as skippable inside Vector's skin.json. This means it is not configurable, meaning we can't make it visible on a single wiki for testing.

To support roll out of the feature a couple of technical changes are required noted in the TODO.

TODO

  • We'll update mediawiki-config SkipSkins to hide the new vector-2022 skin
  • We'll remove the skippable flag inside Vector's skin.json

Sign off steps

  • Prepare a QA task for making sure we are ready to proceed with the skin migration
  • Prepare task for managing the deployment (enabling the new Vector on a single wiki for production testing, then enabling everywhere)
$wgSkipSkins = [ 'vector-2022' ]; $wgVectorSkinMigrationMode = false; $wgDefaultSkin = 'vector';``` => 
```$wgSkipSkins = []; $wgVectorSkinMigrationMode = true;
$wgDefaultSkin = 'vector-2022';

Event Timeline

Change 752760 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Skip vector-2022 skin in config, not Vector skin

https://gerrit.wikimedia.org/r/752760

Change 751964 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Use configuration to skip vector-2022 skin

https://gerrit.wikimedia.org/r/751964

LGoto set the point value for this task to 2.Jan 11 2022, 6:14 PM

Change 752760 merged by jenkins-bot:

[operations/mediawiki-config@master] Skip vector-2022 skin in config, not Vector skin

https://gerrit.wikimedia.org/r/752760

Mentioned in SAL (#wikimedia-operations) [2022-01-13T00:24:17Z] <catrope@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:752760|Skip vector-2022 skin in config, not Vector skin (T298923)]] (duration: 01m 29s)

Change 751964 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use configuration to skip vector-2022 skin

https://gerrit.wikimedia.org/r/751964

Jdlrobson updated the task description. (Show Details)