Page MenuHomePhabricator
Create Task
Maniphest T298942

Fix clipping of icon for IPInfo popups when language is set to ar [S]
Closed, ResolvedPublic
Actions

Description

follows up on T268981#7609125

In T268981#7609125, @dom_walden wrote:

I notice on https://ar.wikipedia.beta.wmflabs.org, I think this change chops off the bottom of the icon (ar and arz use a different icon.)

With overflow: hidden:

ar_icon_hidden.png (42×105 px, 1 KB)

Without:

ar_icon_not_hidden.png (44×108 px, 1 KB)

Another way to see the clipped icon is by adding the param uselang=ar to the querystring (e.g. Special:Log?uselang=ar), or setting the user's language to Arabic via Special:Preferences.

AC:

Details

SubjectRepoBranchLines +/-
Fix clipping of icon for IPInfo popups when language is set to armediawiki/extensions/IPInfomaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

• Prtksxna created this task.Jan 11 2022, 8:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2022, 8:06 AM
• Prtksxna mentioned this in T268981: SPIKE: IPInfo: Dotted lines on revision history jumps when opening popup (only on Firefox) [8H].Jan 11 2022, 8:08 AM
ARamirez_WMF moved this task from Triage/To be Estimated to Pre-estimation/Triage on the Anti-Harassment board.Jan 11 2022, 4:51 PM
Esanders subscribed.EditedJan 12 2022, 3:18 PM

The OOUI icon set has overrides for both directionality and language-specific "fixes". The most used of these is the B/I bold/italic icons which get localised to the local language (e.g. F/K in German), but it is also used in some other cases: In Hebrew and Yiddish, the question mark is /not/ flipped even though they are RTL, and in Arabic this icon is overridden because the 'i' is considered not recognisable to Arabic speakers: T178568.

Unfortunately these variants are not exposed in the OOUI demos: T299061

Esanders mentioned this in T299061: Language-variant icons not shown in OOUI demos.Jan 12 2022, 3:20 PM
• Prtksxna updated the task description. (Show Details)Jan 12 2022, 3:35 PM
Tchanders renamed this task from Use same icon for IPInfo popups an ar and arz wikis to Fix clipping of icon for IPInfo popups on ar and arz wikis.Jan 13 2022, 4:34 PM
STran renamed this task from Fix clipping of icon for IPInfo popups on ar and arz wikis to Fix clipping of icon for IPInfo popups on ar and arz wikis [S].Jan 14 2022, 11:04 PM
STran moved this task from Pre-estimation/Triage to The Letter Song on the Anti-Harassment board.
STran edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
• TThoabala claimed this task.Jan 17 2022, 8:13 AM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Jan 17 2022, 3:01 PM
Tchanders renamed this task from Fix clipping of icon for IPInfo popups on ar and arz wikis [S] to Fix clipping of icon for IPInfo popups when language is set to ar [S].Jan 17 2022, 3:51 PM
Tchanders updated the task description. (Show Details)
gerritbot added a comment.Jan 19 2022, 9:07 AM

Change 755318 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Fix clipping of icon for IPInfo popups when language is set to ar

https://gerrit.wikimedia.org/r/755318

gerritbot added a project: Patch-For-Review.Jan 19 2022, 9:07 AM
• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jan 19 2022, 9:09 AM
• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Jan 19 2022, 7:00 PM
gerritbot added a comment.Jan 19 2022, 7:08 PM

Change 755318 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Fix clipping of icon for IPInfo popups when language is set to ar

https://gerrit.wikimedia.org/r/755318

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2022, 7:10 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 19 2022, 8:00 PM
dom_walden moved this task from QA/Testing 🐞 to Done: Q2 2021-22 on the Anti-Harassment (The Letter Song) board.Jan 24 2022, 9:11 AM

The clipping bug appears to be fixed in Arabic on Firefox, Chrome and Safari on Special:Log, Special:RecentChanges and revision history. I tested zoom levels 100%-200%.

Nor was I able to reproduce the bug in T268981.

For regression purposes, I tested all 5 skins on beta in English, Hebrew and Arabic on Firefox. I did not notice any display issues, apart from T299878.

Test Environment: https://en.wikipedia.beta.wmflabs.org (did not get the version)
Test Browsers: Firefox 91, Chromium 87, Safari 14.

• Niharika closed this task as Resolved.Feb 17 2022, 1:39 AM
• TThoabala mentioned this in T301938: IPInfo: Use infoFilled for the popup button.Mar 15 2022, 5:02 PM
Tchanders mentioned this in T306041: Use 'info' icon for the popup button.Apr 13 2022, 3:26 PM
• Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL