Page MenuHomePhabricator

Keyboard shortcut improvements
Closed, ResolvedPublicFeature

Description

  1. It seems some of the default keyboard shortcuts that videojs has, are not working. Figure out why
  2. Maybe even improve further with https://github.com/ctd1500/videojs-hotkeys
  3. Mobile controls: https://github.com/mister-ben/videojs-mobile-ui

There have been some complaints on the talk page about keyboard binding not working like they do in YT.

Desired shortcuts not yet available:

  1. Seek

Event Timeline

TheDJ triaged this task as Lowest priority.Jan 11 2022, 9:27 AM

Change 753591 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] VideoJS: Basic keyboard shortcuts

https://gerrit.wikimedia.org/r/753591

TheDJ moved this task from Backlog to Active on the VideoJS player board.

Change 753591 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] VideoJS: Basic keyboard shortcuts

https://gerrit.wikimedia.org/r/753591

This is at least a start for keyboard shortcuts, but it's very minimal. We'll likely want to expand on this a bit further.

TheDJ raised the priority of this task from Lowest to Low.Jan 17 2022, 2:04 PM
TheDJ changed the subtype of this task from "Task" to "Feature Request".
TheDJ updated the task description. (Show Details)

Change 789696 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] [WIP]: Testing the videojs-hotkeys plugin

https://gerrit.wikimedia.org/r/789696

Just some prelim testing so far with additional controls.

the videojs-hotkeys package is easy enough, but it does also miss some hotkeys and it adds a lot of config, which we really don't need. Maybe i'll just reimplement it without all those config options

@TheDJ: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Change #1281611 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Video player keyboard shortcuts

https://gerrit.wikimedia.org/r/1281611

Change #789696 abandoned by TheDJ:

[mediawiki/extensions/TimedMediaHandler@master] [WIP]: Testing the videojs-hotkeys plugin

Reason:

in favor of I671e38a9f511caf03d3135a3f1240893f374e631

https://gerrit.wikimedia.org/r/789696

Change #1281611 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Video player keyboard shortcuts

https://gerrit.wikimedia.org/r/1281611

TheDJ claimed this task.