Keyboard shortcut improvements
Closed, ResolvedPublicFeature
Actions

Assigned To

Authored By

	TheDJ
	Jan 11 2022, 9:26 AM

Description

~~It seems some of the default keyboard shortcuts that videojs has, are not working. Figure out why~~
Maybe even improve further with https://github.com/ctd1500/videojs-hotkeys
Mobile controls: https://github.com/mister-ben/videojs-mobile-ui

There have been some complaints on the talk page about keyboard binding not working like they do in YT.

Desired shortcuts not yet available:

Seek

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Video player keyboard shortcuts	mediawiki/extensions/TimedMediaHandler	master	+352 -5
[WIP]: Testing the videojs-hotkeys plugin	mediawiki/extensions/TimedMediaHandler	master	+76 -3
VideoJS: Basic keyboard shortcuts	mediawiki/extensions/TimedMediaHandler	master	+6 -0

Customize query in gerrit

Related Objects

Mentioned In: T422536: 🥳 Wikimedia Hackathon 2026 Project Showcase / Closing Session

Event Timeline

TheDJ created this task.Jan 11 2022, 9:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2022, 9:26 AM

TheDJ triaged this task as Lowest priority.Jan 11 2022, 9:27 AM

Change 753591 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] VideoJS: Basic keyboard shortcuts

https://gerrit.wikimedia.org/r/753591

gerritbot added a project: Patch-For-Review.Jan 12 2022, 11:58 PM

TheDJ claimed this task.Jan 12 2022, 11:59 PM

TheDJ moved this task from Backlog to Active on the VideoJS player board.

Change 753591 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] VideoJS: Basic keyboard shortcuts

https://gerrit.wikimedia.org/r/753591

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 13 2022, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2022, 7:10 PM

This is at least a start for keyboard shortcuts, but it's very minimal. We'll likely want to expand on this a bit further.

TheDJ moved this task from Active to New features on the VideoJS player board.Jan 17 2022, 2:03 PM

TheDJ raised the priority of this task from Lowest to Low.Jan 17 2022, 2:04 PM

TheDJ changed the subtype of this task from "Task" to "Feature Request".

Daimona subscribed.Apr 26 2022, 2:39 PM

TheDJ updated the task description. (Show Details)Apr 28 2022, 8:49 AM

TheDJ updated the task description. (Show Details)May 2 2022, 9:32 AM

TheDJ updated the task description. (Show Details)

TheDJ updated the task description. (Show Details)May 3 2022, 8:24 PM

Change 789696 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] [WIP]: Testing the videojs-hotkeys plugin

https://gerrit.wikimedia.org/r/789696

gerritbot added a project: Patch-For-Review.May 5 2022, 9:28 PM

Just some prelim testing so far with additional controls.

the videojs-hotkeys package is easy enough, but it does also miss some hotkeys and it adds a lot of config, which we really don't need. Maybe i'll just reimplement it without all those config options

Stang subscribed.Aug 24 2022, 11:27 AM

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 12 2024, 11:14 AM

@TheDJ: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!