Page MenuHomePhabricator

[mobile] SE module: Swipe navigation for onboarding modal
Closed, ResolvedPublic

Description

Based on @Sgs's comment a swipe navigation needs to be added to SE onboarding overlay ( see also T294583: Structured Tasks: Enable swiping navigation for onboarding overlay).

  1. The first onboarding modal doesn't have swipe gestures enabled but a continue button (it only has 2 steps). Would it make sense to create a separate task to consolidate the mobile modals behaviour to always have swipe and maybe optional button? I think it's important that similar components behave similarly for the better mobile UX.

Screenshot 2021-12-23 at 12.18.38.png (1×752 px, 151 KB)

Event Timeline

Change 754548 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Add swipe to start editing onboarding dialog

https://gerrit.wikimedia.org/r/754548

I added swipe gestures to the modal. Having a consolidated dialog experience can remain as a nice to have since it's prune to change in the future when we use Vue components.

Change 754548 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add swipe to start editing onboarding dialog

https://gerrit.wikimedia.org/r/754548

Checked on testwiki wmf.19 - works as expected.