Page MenuHomePhabricator
Create Task
Maniphest T299014

[mobile] SE module: Swipe navigation for onboarding modal
Closed, ResolvedPublic
Actions

Description

Based on @Sgs's comment a swipe navigation needs to be added to SE onboarding overlay ( see also T294583: Structured Tasks: Enable swiping navigation for onboarding overlay).

In T298057#7587210, @Sgs wrote:
  1. The first onboarding modal doesn't have swipe gestures enabled but a continue button (it only has 2 steps). Would it make sense to create a separate task to consolidate the mobile modals behaviour to always have swipe and maybe optional button? I think it's important that similar components behave similarly for the better mobile UX.

Screenshot 2021-12-23 at 12.18.38.png (1×752 px, 151 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add swipe to start editing onboarding dialogmediawiki/extensions/GrowthExperimentsmaster+10 -0
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jan 12 2022, 2:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2022, 2:31 AM
Etonkovidova mentioned this in T298057: Account creation: JOSA landing page.Jan 12 2022, 2:34 AM
gerritbot added a comment.Jan 17 2022, 5:10 PM

Change 754548 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Add swipe to start editing onboarding dialog

https://gerrit.wikimedia.org/r/754548

gerritbot added a project: Patch-For-Review.Jan 17 2022, 5:10 PM
Sgs claimed this task.Jan 17 2022, 5:10 PM
Sgs moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
Sgs added a comment.Jan 17 2022, 5:14 PM

I added swipe gestures to the modal. Having a consolidated dialog experience can remain as a nice to have since it's prune to change in the future when we use Vue components.

Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 17 2022, 5:14 PM
gerritbot added a comment.Jan 19 2022, 6:21 PM

Change 754548 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add swipe to start editing onboarding dialog

https://gerrit.wikimedia.org/r/754548

• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 19 2022, 6:26 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 19 2022, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 19 2022, 7:10 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 25 2022, 1:13 AM
Etonkovidova closed this task as Resolved.Jan 25 2022, 11:48 PM

Checked on testwiki wmf.19 - works as expected.

Urbanecm_WMF added a project: GrowthExperiments-NewcomerTasks.Jan 21 2026, 2:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits