Page MenuHomePhabricator

VE Dialog: Clicking template or parameter name scrolls it to top of dialog
Closed, ResolvedPublic0 Estimated Story Points

Description

Background

In usability testing the synced scrolling was difficult for users to discover and they were particularly confused when clicking did nothing (when an element was in view but not at the top). This should help users discover the feature, but also help the information they want be more easily findable.

For reference: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView
Might be easier after we disconnect the old sidebar (because this might be hidden in the BookletLayout class) - do we investigate now or save this for later?

Requirements

  • In the sidebar, if the user clicks the name of a template, then it scrolls into view on the right-hand side with the template name visible at the top of the pane. If the template is already in view, but the name is not at the top, then it should still scroll to the top.
  • In the sidebar, if the user clicks the name of a checked/added parameter, then it scrolls into view on the right-hand side with the parameter label visible at the top of the pane. If the parameter is already in view, but the name is not at the top, then it should scroll to the top.
  • If user adds a new template (to multi-part or creating multi-part), the search component appears and scrolls to to top.
  • If user adds a wikitext element, the field appears and scrolls to top.
  • In any case, if the element is already at the top of the pane, then nothing happens. (For example if they click it for a second time after the scroll has happened already)
  • If element is near the bottom and cannot scroll to top, it should scroll up as far as it can.
  • Applies to desktop, minerva, and narrow mode

Specs

When elements scroll to top, there should be padding equal to the height of the label text

Event Timeline

ECohen_WMDE set the point value for this task to 8.Jan 13 2022, 8:53 AM

Change 753982 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Clicking template or parameter name scrolls it to top of dialog

https://gerrit.wikimedia.org/r/753982

Change 753987 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[oojs/ui@master] Added alignToTop as an option to scrollIntoView

https://gerrit.wikimedia.org/r/753987

WMDE-Fisch changed the point value for this task from 8 to 3.
WMDE-Fisch subscribed.

Note: Might be that we cannot solve this until the old sidebar is removed and the code workflow a bit cleaner. Let's give it another try though capped at 3 story points.

Note: Might be that we cannot solve this until the old sidebar is removed and the code workflow a bit cleaner. Let's give it another try though capped at 3 story points.

We just had longer dev talk about this and we really would like to postpone the implementation until the old sidebar and the booklet layout are removed when we kill feature switches in a final cleanup.

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/2c43f6ce4f/w/

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/2c43f6ce4f/w/

Added two new requirements, not sure they will impact the story points.

Tobi_WMDE_SW subscribed.

more requirements got added so this needs re-estimation.

Change 753987 merged by jenkins-bot:

[oojs/ui@master] Added alignToTop as an option to scrollIntoView

https://gerrit.wikimedia.org/r/753987

lilients_WMDE updated the task description. (Show Details)
lilients_WMDE set the point value for this task to 5.

I checked all requirements for desktop, mobile and narrow. Only thing that differs a bit, is a missing padding in narrow mode after switching from sidebar to content pane. We can check that in sprint demo and create a follow up if needed.

Can be demoed locally. Otherwise waiting for OOUI release and deployment.

Change 753982 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Clicking template or parameter name scrolls it to top of dialog

https://gerrit.wikimedia.org/r/753982

awight changed the point value for this task from 5 to 0.Jul 6 2022, 8:39 AM

Change 813630 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Update OOUI to v0.44.1

https://gerrit.wikimedia.org/r/813630

Change 813630 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.44.1

https://gerrit.wikimedia.org/r/813630

Change 814161 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Don't fire selection events for deleted parameters

https://gerrit.wikimedia.org/r/814161

Lena_WMDE claimed this task.
Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-07-06 board.