Sticky Header does not appear in read mode after abandoning an edit in VE
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Jan 13 2022, 3:01 AM

Description

This task is about resolving an issue where the site-wise sticky header does not appear in read mode after exiting VE without publishing a change.

Behavior

Visit https://patchdemo.wmflabs.org/wikis/557db5804f/w/index.php?title=Special:UserLogin&returnto=Douglas+Adams
Log in (User: Patch Demo; PW: patchdemo1)
Scroll the page so the page chrome is no longer in view
Open VE using any affordance on the page (e.g. Edit within the page chrome, a section [ edit ] link, or the ✏️ within the sticky header)
Exit VE by pressing Escape or the browser's back button

Actual
❗️ Notice the site-wide sticky header does NOT appear unless you scroll back to the top of the page and scroll back down again

Expected
✅ Notice the site-wide sticky header appears

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Sticky header: Wait for some repainting to happen after VE teardown	mediawiki/skins/Vector	master	+5 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T283505 [EPIC] Fixed "sticky" site header
Resolved	Jdlrobson	T287545 [EPIC] Introduce editing functionality to the sticky header
Resolved	ppelberg	T294506 Run A/B test to evaluate impact of sticky header editing affordance
Resolved	ppelberg	T299114 Sticky Header does not appear in read mode after abandoning an edit in VE

Event Timeline

ppelberg created this task.Jan 13 2022, 3:01 AM

ppelberg updated the task description. (Show Details)

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog-Archived board.Jan 14 2022, 12:28 AM

Esanders updated the task description. (Show Details)Jan 14 2022, 2:21 PM

Change 753970 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Sticky header: Wait for some repainting to happen after VE teardown

https://gerrit.wikimedia.org/r/753970

gerritbot added a project: Patch-For-Review.Jan 14 2022, 2:46 PM

Test wiki created on Patch demo by Ed g2s using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/3259638fe6/w/

https://patchdemo.wmflabs.org/wikis/3259638fe6/wiki/Douglas_Adams

Change 753970 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Sticky header: Wait for some repainting to happen after VE teardown

https://gerrit.wikimedia.org/r/753970

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 14 2022, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2022, 5:10 PM

matmarex mentioned this in T296910: [Implementation] Introduce editing functionality to sticky header.Jan 14 2022, 9:17 PM

matmarex moved this task from Inbox to QA on the Editing-team (Kanban Board) board.

matmarex added a project: Editing QA.

ovasileva moved this task from Not ready to estimate to Tracking on the Web-Team-Backlog-Archived board.Jan 17 2022, 1:53 PM

Tested at: https://patchdemo.wmflabs.org/wikis/557db5804f/w/index.php?title=Special:UserLogin&returnto=Douglas+Adams
This is still happening when I press the browser's back button in step 5.

Ryasmeen removed a project: Editing QA.Jan 17 2022, 4:56 PM

That's an old demo and it can't be updated, can you test on the beta cluster instead? e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?useskinversion=2&vectorstickyheader=1&vectorstickyheaderedit=1

In T299114#7626981, @matmarex wrote:

That's an old demo and it can't be updated, can you test on the beta cluster instead? e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?useskinversion=2&vectorstickyheader=1&vectorstickyheaderedit=1

works on the beta cluster, Thanks @matmarex.

Ryasmeen edited projects, added Verified; removed Editing QA.Jan 18 2022, 9:20 AM

ppelberg closed this task as Resolved.Jan 19 2022, 12:59 AM

ppelberg claimed this task.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 19 2022, 1:00 AM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/3259638fe6/w/~~

Sticky Header does not appear in read mode after abandoning an edit in VEClosed, ResolvedPublicActions