Page MenuHomePhabricator

Can't view old Vector on beta cluster via query string
Open, MediumPublic3 Estimated Story Points

Description

Following the migration test run, I'm seeing some issues with the display of old Vector when using the useskin querystring parameter.

Test case 1

Expected: I should see the old Vector.
Actual: I see the modern Vector experience.

Test case 1

Expected: I should see the old Vector.
Actual: I see the modern Vector experience.

Developer notes

When VectorSkinMigrationMode is enabled, then skinversion query string parameter should cease to work.
For anons, wgDefaultSkin should be the source of truth in this situation for which skin to use.

For logged in users, we consult the user preferences table:

  • If skin is set to 'vector' and skin version is 2, we give them modern Vector.
  • If skin is set to 'vector' and skin version is 2, but skinversion query string parameter is set to 1, we give them legacy to allow them to override
  • If skin is set to 'vector' and skin version is 1, we give them old Vector.

Event Timeline

Change 753821 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] WIP: Fix useskin=vector

https://gerrit.wikimedia.org/r/753821

Jdlrobson renamed this task from Can't always view old Vector on beta cluster to Can't view old Vector on beta cluster via query string.Fri, Jan 14, 12:32 AM
Jdlrobson triaged this task as Medium priority.
Jdlrobson updated the task description. (Show Details)

So apparently this is inheriting how it currently works when the default skin is Vector: e.g. https://fr.wikipedia.org/?useskin=vector
While only temporary, this does create a problem for people that need to test features for anonymous users in the old skin on the beta cluster so I'm looking into a fix.

Change 755036 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Respect useskin when operating in MigrationMode

https://gerrit.wikimedia.org/r/755036

bwang added a subscriber: bwang.
cjming moved this task from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
cjming added a subscriber: cjming.

Change 755036 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Respect useskin when operating in MigrationMode

https://gerrit.wikimedia.org/r/755036