Hi @schoenbaechler
I wanted to discuss 2 things:

1. The comment line in the revision details, may be we should mimic the ios designs and have it at the right bottom like this:

https://www.figma.com/file/XuMaiGvAgrJKvsm2esbm75/Edit-history-T297759?node-id=163%3A2263

Because, for many edits, there are no comments and having it at the top leaves a bad blank space:

2. Is it ok if we just say the size in bytes [150,210], like we see here in the edit history:

Thank you :)

Thanks @Sharvaniharan, good questions 🙃

In T299178#7658435, @Sharvaniharan wrote:

Hi @schoenbaechler
I wanted to discuss 2 things:

1. The comment line in the revision details, may be we should mimic the ios designs and have it at the right bottom like this:

https://www.figma.com/file/XuMaiGvAgrJKvsm2esbm75/Edit-history-T297759?node-id=163%3A2263

Because, for many edits, there are no comments and having it at the top leaves a bad blank space:

If there’s no edit summary, can we instead show a preview of the edit itself? I think that’d be more helpful.

2. Is it ok if we just say the size in bytes [150,210], like we see here in the edit history:

instead of character count [69]?
We can change the color to something less prominent and display as %d bytes. This will save one more api call, as it is hard to convert the bytes size to char count here.
[This is a minor one, so if you need the count, that is fine]

Thank you :)

Sounds good to me!

Hi @schoenbaechler .. Please use this link to test : https://github.com/wikimedia/apps-android-wikipedia/pull/3077/checks

Because, for many edits, there are no comments and having it at the top leaves a bad blank space:

If there’s no edit summary, can we instead show a preview of the edit itself? I think that’d be more helpful.

Somewhat disagree. Showing a preview of the edit will almost certainly not show the actual spot where the change was made; there's simply too much contextual text surrounding the diff for this to be useful.

It would be more useful to state explicitly that there was no comment included with the edit. This is an indication that the edit might not be good quality.

Looks good so far @Sharvaniharan, great work! 👍

01)

Can we make these items *not* behave like buttons? Tapping the entire card should lead users to the detail view. Tapping an item highlights it but it does not navigate to the detail screen, see this video:

https://www.dropbox.com/s/d3exm40k1k4dh0b/screen-20220218-173839.mp4?dl=0

02)

Some things aren’t 100% aligned yet, please check the specs on Figma

@schoenbaechler Thank you so much for the review. I have fixed these issues. Please review them https://github.com/wikimedia/apps-android-wikipedia/pull/3077/checks.

However, this still doesn't eliminate the use of another api call for each row, so I also changed the diff size to just be expressed in bytes. I created a separate branch for you to review how that would look. Please take a look at that here: https://github.com/wikimedia/apps-android-wikipedia/pull/3134/checks If that looks good, we can go with that approach as well.

Thanks @Sharvaniharan

01)

Can we make these items *not* behave like buttons? Tapping the entire card should lead users to the detail view. Tapping an item highlights it but it does not navigate to the detail screen, see this video:

https://www.dropbox.com/s/d3exm40k1k4dh0b/screen-20220218-173839.mp4?dl=0

Can we remove the hover animation / highlight on the buttons on when long pressing a card item?

02)

Some things aren’t 100% aligned yet, please check the specs on Figma

Looks good now!

Quickly wanted to tag @JTannerWMF for consultation. Sharvani and Dmitry mentioned that previewing the edit, when there is no edit summary, might cause performance issues (too many API calls), so they are suggesting to show copy that there’s no edit summary, like this 👇

I’m not the biggest fan of this solution but also acknowledge that our options are limited. IMO the copy could be streamlined from There is no comment associated with this edit' to No edit summary`, Empty edit summary or something like that. Thoughts @JTannerWMF ? Thx!

Hi @scblr
I have fixed the ripple issue and updated the copy to "Empty edit summary". Please review and let me know.
[Note: I have updated the APK link. Please download from the new one again]

@Sharvaniharan
The design specifies different avatar icons for different types of edits:

• regular user (current avatar icon)
• bot edit (robot icon)
• anonymous edit (hat-with-glasses icon)

Thanks @Dbrant . @scblr Did this change as well. ^ The api response doesnt give the info for a bot edit, so you will only see 2 types of user icons, regular for logged in and the hat-with-glasses for anon users

@Sharvaniharan, thanks for the update!

I see this in the latest apk from the task’s description 👇

... seems like there’s an issue with retrieving the amount of bytes? thanks for checking! (I’ve set my system and primary app language to German in case you need to reproduce it, article: Ukraine)

the rest looks good Sharvani (👏) and thx @Dbrant for the hint re: iconography!

@scblr Thank you for the review..

This will get fixed in an upcoming build that Dmitry is working on. Actually the current alpha has it if you want to check it out :)

looks good to me now @Sharvaniharan — per discussion with @Dbrant last week: we’re going to remove the button style for the byte indicator in the list view cards and move the username button to the most left position.

... thanks for working on this!

Working for me on 2.7.50400-alpha-2022-05-05