Page MenuHomePhabricator
Create Task
Maniphest T299194

Test Z8013 for Z801/Echo fails
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • New wiki. Go to Z801

What happens?:
You can see that the test for Z8013 fails.

The test is wrong: it uses Z866/String equality for the result condition, but since we are expecting a list, that is a type error. We would need a List equality for this. Since List equality is not a built-in (IIRC) we cannot have this test as a built-in test.

What should have happened instead?:
All built-in tests should pass.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects

Event Timeline

DVrandecic created this task.Jan 14 2022, 3:41 AM
DVrandecic moved this task from To Triage to Phase η – Generic types on the Abstract Wikipedia team board.Jan 18 2022, 5:07 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Jan 18 2022, 5:27 PM
DVrandecic moved this task from Ready to do to Needs discussion/DoD on the Abstract Wikipedia team (Phase η – Generic types) board.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks; removed Abstract Wikipedia team (Phase η – Generic types).Feb 8 2022, 5:42 PM
cmassaro subscribed.Sep 26 2022, 3:44 PM

Should we add List equality as a built-in, then? Or just remove this test?

Jdforrester-WMF subscribed.Sep 26 2022, 3:49 PM
In T299194#8261245, @cmassaro wrote:

Should we add List equality as a built-in, then? Or just remove this test?

Can we recurse through the list with a Map() applying the StringEquality()?

Jdforrester-WMF moved this task from Incoming to Blocking launch on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:27 PM
Jdforrester-WMF mentioned this in T320509: Rework/rewrite the wikilambda_perform_test API.Nov 21 2022, 8:09 PM
EWright claimed this task.Dec 2 2022, 4:00 PM
EWright added a comment.Dec 5 2022, 2:02 PM
In T299194#8261275, @Jdforrester-WMF wrote:
In T299194#8261245, @cmassaro wrote:

Should we add List equality as a built-in, then? Or just remove this test?

Can we recurse through the list with a Map() applying the StringEquality()?

@Jdforrester-WMF, do you mean this is what our built-in implementation for List<String> equality could look like?

Jdforrester-WMF added a comment.Dec 5 2022, 5:06 PM
In T299194#8442755, @EWright-WMF wrote:
In T299194#8261275, @Jdforrester-WMF wrote:
In T299194#8261245, @cmassaro wrote:

Should we add List equality as a built-in, then? Or just remove this test?

Can we recurse through the list with a Map() applying the StringEquality()?

@Jdforrester-WMF, do you mean this is what our built-in implementation for List<String> equality could look like?

Yes, possibly, but mostly I meant that we could write the verification call here to be a booleanEquality() of recursively booleanAnd()ing through the results of a map of stringEquality() because in this case we know it's a list of Z6/Strings (which isn't generally true).

EWright added a comment.EditedDec 6 2022, 5:31 PM

As James was (I think) suggesting, we don't actually strictly need a built-in implementation to achieve a list equality function. As a POC, I created a new function in beta, 'List of Strings equality', and a recursive composition implementation: https://wikifunctions.beta.wmflabs.org/wiki/Z10338. This function and implementation are specifically for testing equality of List<String>, but you could make a more general list equality function by adding another argument for an equality function, and then calling this when comparing individual elements. I tried doing this, but there are some (I think) bugs preventing setting Z7K1 to an argument reference (T324600, T324597).

@Jdforrester-WMF, @cmassaro: given we can implement a list equality function using composition, does that mean we wouldn't want to create a built-in implementation?

Re: the actual topic of this ticket (Z8013 not passing), the above discussion is for now a moot point. The test is failing before the validation step is ever reached. I'm looking into this.

EWright mentioned this in T314621: ZObjectFactory::create() throwing more exceptions when called from ApiPerformTest.php.Dec 7 2022, 5:22 PM
EWright added a comment.Dec 7 2022, 5:30 PM

Re: the actual topic of this ticket (Z8013 not passing), the above discussion is for now a moot point. The test is failing before the validation step is ever reached. I'm looking into this.

The problem is that Z8013 is not compatible with the way we execute Testers in the PHP layer - its Z20K2 is not a call to the function under test, as the PHP layer expects. I don't think there's currently any way to create a Tester for Echo's list case without adding a separate persisted function, like the one I link above.

EWright added a comment.Dec 12 2022, 11:12 AM

We agreed in the AW Engineering meeting that we would create a predefined List Equality function, with a built-in implementation, to use in this test.

gerritbot added a comment.Dec 16 2022, 11:43 AM

Change 868643 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/services/function-schemata@master] Add List Equality Factory function and implementation definitions.

https://gerrit.wikimedia.org/r/868643

gerritbot added a project: Patch-For-Review.Dec 16 2022, 11:43 AM
EWright added a comment.Dec 19 2022, 2:46 PM

Waiting on comment from team on this doc, presenting two options for a list equality function.

gerritbot added a comment.Dec 20 2022, 10:26 AM

Change 868643 abandoned by EWright:

[mediawiki/services/function-schemata@master] Add List Equality Factory function and implementation definitions.

Reason:

https://gerrit.wikimedia.org/r/868643

Maintenance_bot removed a project: Patch-For-Review.Dec 20 2022, 10:30 AM
gerritbot added a comment.Dec 22 2022, 4:05 PM

Change 870927 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/services/function-schemata@master] Add validator for Z40 to schema.js.

https://gerrit.wikimedia.org/r/870927

gerritbot added a project: Patch-For-Review.Dec 22 2022, 4:05 PM
gerritbot added a comment.Dec 22 2022, 5:24 PM

Change 870927 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add validator for Z40 to schema.js.

https://gerrit.wikimedia.org/r/870927

EWright mentioned this in rMSFS37f411913ca5: Add validator for Z40 to schema.js..Dec 22 2022, 5:25 PM
EWright mentioned this in rMSFS7b5893d8e7e7: Add definitions for List equality function and built-in impl..Dec 22 2022, 5:27 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 22 2022, 5:30 PM
gerritbot added a comment.Dec 22 2022, 6:23 PM

Change 870963 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (37f70b3)

https://gerrit.wikimedia.org/r/870963

gerritbot added a project: Patch-For-Review.Dec 22 2022, 6:23 PM
gerritbot added a comment.Dec 22 2022, 8:30 PM

Change 870963 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (37f70b3)

https://gerrit.wikimedia.org/r/870963

EWright mentioned this in rMSFO2f60c619ddc8: Update function-schemata sub-module to HEAD (37f70b3).Dec 22 2022, 8:30 PM
gerritbot added a comment.Jan 3 2023, 11:41 AM

Change 870551 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/services/function-orchestrator@master] [WIP] Implement Z989 (built-in implementation for List equality).

https://gerrit.wikimedia.org/r/870551

gerritbot added a comment.Jan 4 2023, 3:10 PM

Change 875325 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (f19bc13)

https://gerrit.wikimedia.org/r/875325

gerritbot added a comment.Jan 4 2023, 3:10 PM

Change 875346 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (f19bc13)

https://gerrit.wikimedia.org/r/875346

gerritbot added a comment.Jan 4 2023, 3:10 PM

Change 875324 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (f19bc13)

https://gerrit.wikimedia.org/r/875324

gerritbot added a comment.Jan 4 2023, 6:13 PM

Change 870551 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Implement Z989 (built-in implementation for List equality).

https://gerrit.wikimedia.org/r/870551

EWright mentioned this in rMSFO67a7569ea6cf: Implement Z989 (built-in implementation for List equality)..Jan 4 2023, 6:14 PM
gerritbot added a comment.Jan 4 2023, 7:42 PM

Change 875346 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (f19bc13)

https://gerrit.wikimedia.org/r/875346

Jdforrester-WMF mentioned this in rMTWC013826f9802b: Update function-schemata sub-module to HEAD (f19bc13).Jan 4 2023, 7:43 PM
gerritbot added a comment.Jan 4 2023, 7:45 PM

Change 875325 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (f19bc13)

https://gerrit.wikimedia.org/r/875325

Jdforrester-WMF mentioned this in rMSFE0bfe83bc59a2: Update function-schemata sub-module to HEAD (f19bc13).Jan 4 2023, 7:46 PM
gerritbot added a comment.Jan 4 2023, 7:53 PM

Change 875324 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (f19bc13)

https://gerrit.wikimedia.org/r/875324

gerritbot added a comment.Jan 11 2023, 1:09 PM

Change 878936 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/services/function-schemata@master] Fix Z8013 - Echo Tester for Typed List.

https://gerrit.wikimedia.org/r/878936

gerritbot added a comment.Jan 11 2023, 3:19 PM

Change 878936 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Fix Z8013 (Echo Tester for Typed List).

https://gerrit.wikimedia.org/r/878936

EWright closed this task as Resolved.Jan 11 2023, 3:19 PM
EWright mentioned this in rMSFSebe6b6b31723: Fix Z8013 (Echo Tester for Typed List)..Jan 11 2023, 3:20 PM
gerritbot added a comment.Jan 11 2023, 8:28 PM

Change 879128 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (4093097)

https://gerrit.wikimedia.org/r/879128

gerritbot added a comment.Jan 11 2023, 8:28 PM

Change 879129 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (4093097)

https://gerrit.wikimedia.org/r/879129

gerritbot added a comment.Jan 11 2023, 8:28 PM

Change 879130 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (4093097)

https://gerrit.wikimedia.org/r/879130

gerritbot added a comment.Jan 11 2023, 8:29 PM

Change 878138 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (4093097)

https://gerrit.wikimedia.org/r/878138

gerritbot added a comment.Jan 11 2023, 9:14 PM

Change 878138 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (4093097)

https://gerrit.wikimedia.org/r/878138

gerritbot added a comment.Jan 13 2023, 11:01 PM

Change 879128 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (4093097)

https://gerrit.wikimedia.org/r/879128

Jdforrester-WMF mentioned this in rMTWC32f41e00f111: Update function-schemata sub-module to HEAD (4093097).Jan 13 2023, 11:03 PM
gerritbot added a comment.Jan 13 2023, 11:03 PM

Change 879129 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (4093097)

https://gerrit.wikimedia.org/r/879129

gerritbot added a comment.Jan 13 2023, 11:03 PM

Change 879130 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (4093097)

https://gerrit.wikimedia.org/r/879130

Jdforrester-WMF mentioned this in rMSFE2dac99875d3d: Update function-schemata sub-module to HEAD (4093097).Jan 13 2023, 11:06 PM
Jdforrester-WMF mentioned this in rMSFO69c55b32ddb1: Update function-schemata sub-module to HEAD (4093097).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits