Page MenuHomePhabricator
Create Task
Maniphest T299222

Properly configure logback for W[CD]QS streaming updater
Closed, ResolvedPublic
Actions

Description

As an operator of W[CD]QS, I want to have local access to the logs and I want the configuration files to reflect the reality of the service so that I can properly diagnose potential issues.

Currently, we have a logback configuration in /etc/query_service/logback-wcqs-updater.xml, but that isn't loaded as our startup scripts don't configure -Dlogback.configurationFile=.

AC:

  • changes to logback configuration files are properly reflected in the streaming updater
  • logs are available on disk as expected in /var/log/query_service/
  • code is simplified to account for the differentiation between WCQS and WDQS

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove BC for varied default file pathwikidata/query/rdfmaster+0 -4
rdf query service: Use constant filename for defaultsoperations/puppetproduction+1 -1
Deparameterize streaming updater defaults pathwikidata/query/rdfmaster+4 -2
Deparameterize streaming updater defaults pathwikidata/query/deploymaster+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Gehel created this task.Jan 14 2022, 2:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2022, 2:16 PM
Maintenance_bot added a project: Wikidata.Jan 14 2022, 2:45 PM
Gehel moved this task from Incoming to Current work on the Wikidata-Query-Service board.Jan 17 2022, 4:18 PM
Gehel added a project: Discovery-Search (Current work).
• MPhamWMF set the point value for this task to 3.Jan 24 2022, 4:55 PM
• MPhamWMF moved this task from Incoming to Ready for Dev -- SWE on the Discovery-Search (Current work) board.
Gehel updated the task description. (Show Details)Jan 24 2022, 4:55 PM
Gehel removed the point value 3 for this task.
EBernhardson claimed this task.Jan 24 2022, 9:12 PM
EBernhardson moved this task from Ready for Dev -- SWE to In Progress on the Discovery-Search (Current work) board.
gerritbot added a comment.Jan 26 2022, 1:16 AM

Change 757124 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[operations/puppet@production] rdf query service: Use constant filename for defaults

https://gerrit.wikimedia.org/r/757124

gerritbot added a project: Patch-For-Review.Jan 26 2022, 1:16 AM
EBernhardson moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.Jan 26 2022, 1:16 AM
gerritbot added a comment.Jan 26 2022, 1:20 AM

Change 757146 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[wikidata/query/deploy@master] Deparameterize streaming updater defaults path

https://gerrit.wikimedia.org/r/757146

gerritbot added a comment.Jan 26 2022, 7:29 PM

Change 757146 abandoned by Ebernhardson:

[wikidata/query/deploy@master] Deparameterize streaming updater defaults path

Reason:

wrong codebase

https://gerrit.wikimedia.org/r/757146

gerritbot added a comment.Jan 26 2022, 7:51 PM

Change 757514 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[wikidata/query/rdf@master] Deparameterize streaming updater defaults path

https://gerrit.wikimedia.org/r/757514

gerritbot added a comment.Jan 26 2022, 11:08 PM

Change 757514 merged by jenkins-bot:

[wikidata/query/rdf@master] Deparameterize streaming updater defaults path

https://gerrit.wikimedia.org/r/757514

gerritbot added a comment.Feb 1 2022, 1:23 AM

Change 757124 merged by Ryan Kemper:

[operations/puppet@production] rdf query service: Use constant filename for defaults

https://gerrit.wikimedia.org/r/757124

Stashbot added a comment.Feb 1 2022, 1:24 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-01T01:24:59Z] <ryankemper> T299222 Merged https://gerrit.wikimedia.org/r/c/operations/puppet/+/757124; running puppet on w*qs* before purging old filepaths

Stashbot added a comment.Feb 1 2022, 1:42 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-01T01:42:35Z] <ryankemper> T299222 ryankemper@cumin1001:~$ sudo cumin 'wdqs*' 'sudo rm -fv /etc/default/wdqs-updater'

Stashbot added a comment.Feb 1 2022, 1:42 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-01T01:42:41Z] <ryankemper> T299222 ryankemper@cumin1001:~$ sudo cumin 'wcqs*' 'sudo rm -fv /etc/default/wcqs-updater'

Gehel added a parent task: T244590: [Epic] Rework the WDQS updater as an event driven application.Feb 7 2022, 10:32 AM
gerritbot added a comment.Feb 7 2022, 6:47 PM

Change 760633 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[wikidata/query/rdf@master] Remove BC for varied default file path

https://gerrit.wikimedia.org/r/760633

EBernhardson added a comment.EditedFeb 7 2022, 6:48 PM

Logs themselves have been flowing for a while now, since the patch merge on Jan 26. I put up one more cleanup patch, after that i believe this should be complete. We don't need to do a deploy for this patch, it can run with whatever the next deployment is.

gerritbot added a comment.Feb 8 2022, 10:52 AM

Change 760633 merged by jenkins-bot:

[wikidata/query/rdf@master] Remove BC for varied default file path

https://gerrit.wikimedia.org/r/760633

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Feb 14 2022, 7:56 PM
EBernhardson removed a project: Patch-For-Review.

doesn't look like there are any more patches here, removing patch-for-review

Gehel closed this task as Resolved.Feb 21 2022, 2:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits