Maniphest T299305

ULS compatibility issue with <1.37: Using $this when not in object context
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikerabbit
	Jan 16 2022, 11:34 AM

Tags

Referenced Files

None

Subscribers

Description

See https://www.mediawiki.org/wiki/Topic:Wnw7vp1a1156g71x and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/734888/comment/2c1e95c8_351d62cd/

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/UniversalLanguageSelector	master	+11 -12	Move version check inside PersonalUrls hook

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		abi_	T298889 Release MLEB 2022.01
		Resolved		abi_	T299305 ULS compatibility issue with <1.37: Using $this when not in object context

Event Timeline

Nikerabbit created this task.Jan 16 2022, 11:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2022, 11:34 AM

Nikerabbit added a parent task: T298889: Release MLEB 2022.01.Jan 16 2022, 11:34 AM

Change 755641 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] Move version check inside PersonalUrls hook

https://gerrit.wikimedia.org/r/755641

gerritbot added a project: Patch-For-Review.Jan 20 2022, 8:40 AM

abi_ changed the task status from Open to In Progress.Jan 20 2022, 11:09 AM

abi_ claimed this task.

abi_ triaged this task as Medium priority.

abi_ added a project: Language-Team (Language-2022-January-March).

abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-January-March) board.

Change 755641 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Move version check inside PersonalUrls hook

https://gerrit.wikimedia.org/r/755641

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 24 2022, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2022, 10:10 AM

Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-January-March) board.Jan 24 2022, 12:22 PM

Tested during MLEB release with MW 1.36.