Page MenuHomePhabricator

Unset IPInfo as Global Preference [S]
Closed, ResolvedPublic

Description

Following the issue reported in T298977#7613214 we want to unset IP Info preferences as Global Preferences for now. We will revisit whether to allow Global Preferences in T298977.

Must have:

  • Install GlobalPrerefences extension

https://gerrit.wikimedia.org/r/admin/repos/mediawiki/extensions/GlobalPreferences

  • Enable the extension in your LocalSettings ( wfLoadExtension("GlobalPreferences"); )

Acceptance Criteria:

  • IP info doesn't show anymore on Special:GlobalPreferences

Notes:

  • GlobalPreferences checks whether preferences can be global here
  • IPInfo adds preferences here
  • Example of another extension disallowing their preferences from being global can be seen here

Event Timeline

Tchanders renamed this task from Unset IPInfo as global Preferences to Unset IPInfo as Global Preference.Jan 18 2022, 3:58 AM
Tchanders updated the task description. (Show Details)
Tchanders renamed this task from Unset IPInfo as Global Preference to Unset IPInfo as Global Preference [S].Jan 19 2022, 6:07 PM
Tchanders moved this task from Pre-estimation/Triage to The Letter Song on the Anti-Harassment board.

Change 756048 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Unset IPInfo as Global Preference

https://gerrit.wikimedia.org/r/756048

Change 756048 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Unset IPInfo as Global Preference

https://gerrit.wikimedia.org/r/756048

Confirmed IP info doesn't show anymore on Special:GlobalPreferences

Screen Shot 2022-01-24 at 5.57.11 PM.png (1×2 px, 443 KB)

@TThoabala Are we also going to unset the beta feature as a Global Preference?

gp_beta.png (813×1 px, 87 KB)

@TThoabala Are we also going to unset the beta feature as a Global Preference?

gp_beta.png (813×1 px, 87 KB)

@dom_walden I am not sure about this, but I would be happy to create a ticket and work on that too. @Tchanders/@Niharika should we also do this ?

@TThoabala Are we also going to unset the beta feature as a Global Preference?

@dom_walden I am not sure about this, but I would be happy to create a ticket and work on that too. @Tchanders/@Niharika should we also do this ?

I think it makes sense to unset the BetaFeature global preference too, and revisit that in T298977: Investigate setting IPInfo user preferences as Global Preferences.

@TThoabala Feel free to make a follow-up task. The BetaFeature preference is set here.

I think it is not a good idea to remove IP info from global preferences, because there are many users who do cross wiki work heavily, and having to go to preferences manually on nearly a thousand of wikis is boring, tedious and doesn't bring any advantages. Can we bring IP info back to global preferences?