Page MenuHomePhabricator
Create Task
Maniphest T299472

PHP Deprecated: Use of MediaWiki\Deferred\LinksUpdate\LinksUpdate::$mImages was deprecated in MediaWiki 1.38. [Called from MediaWiki\Extension\GlobalUsage\Hooks::onLinksUpdateComplete]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Deferred\LinksUpdate\LinksUpdate::$mImages was deprecated in MediaWiki 1.38. [Called from MediaWiki\Extension\GlobalUsage\Hooks::onLinksUpdateComplete]
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.18/extensions/GlobalUsage/includes/Hooks.php(35)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.38.0-wmf.18/includes/debug/MWDebug.php(377): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.38.0-wmf.18/includes/debug/MWDebug.php(353): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.38.0-wmf.18/includes/debug/MWDebug.php(232): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.18/includes/GlobalFunctions.php(1005): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.38.0-wmf.18/includes/debug/DeprecationHelper.php(191): wfDeprecated(string, string, NULL, integer)
#6 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/LinksUpdate/LinksUpdate.php(424): MediaWiki\Deferred\LinksUpdate\LinksUpdate->__get(string)
#7 /srv/mediawiki/php-1.38.0-wmf.18/extensions/GlobalUsage/includes/Hooks.php(35): MediaWiki\Deferred\LinksUpdate\LinksUpdate->getImages()
#8 /srv/mediawiki/php-1.38.0-wmf.18/includes/HookContainer/HookContainer.php(338): MediaWiki\Extension\GlobalUsage\Hooks::onLinksUpdateComplete(MediaWiki\Deferred\LinksUpdate\LinksUpdate, integer)
#9 /srv/mediawiki/php-1.38.0-wmf.18/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#10 /srv/mediawiki/php-1.38.0-wmf.18/includes/HookContainer/HookRunner.php(2310): MediaWiki\HookContainer\HookContainer->run(string, array)
#11 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/LinksUpdate/LinksUpdate.php(261): MediaWiki\HookContainer\HookRunner->onLinksUpdateComplete(MediaWiki\Deferred\LinksUpdate\LinksUpdate, integer)
#12 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/AutoCommitUpdate.php(44): MediaWiki\Deferred\LinksUpdate\LinksUpdate->MediaWiki\Deferred\LinksUpdate\{closure}(Wikimedia\Rdbms\MaintainableDBConnRef, string)
#13 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/DeferredUpdates.php(529): AutoCommitUpdate->doUpdate()
#14 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/DeferredUpdates.php(414): DeferredUpdates::attemptUpdate(AutoCommitUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#15 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/DeferredUpdates.php(240): DeferredUpdates::run(AutoCommitUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#16 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(AutoCommitUpdate, integer)
#17 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#18 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/DeferredUpdates.php(243): DeferredUpdatesScope->processUpdates(integer, Closure)
#19 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#20 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#21 /srv/mediawiki/php-1.38.0-wmf.18/includes/deferred/DeferredUpdates.php(248): DeferredUpdatesScope->processUpdates(integer, Closure)
#22 /srv/mediawiki/php-1.38.0-wmf.18/includes/MediaWiki.php(1114): DeferredUpdates::doUpdates()
#23 /srv/mediawiki/php-1.38.0-wmf.18/includes/MediaWiki.php(839): MediaWiki->restInPeace()
#24 /srv/mediawiki/php-1.38.0-wmf.18/includes/MediaWiki.php(588): MediaWiki->doPostOutputShutdown()
#25 /srv/mediawiki/php-1.38.0-wmf.18/index.php(53): MediaWiki->run()
#26 /srv/mediawiki/php-1.38.0-wmf.18/index.php(46): wfIndexMain()
#27 /srv/mediawiki/w/index.php(3): require(string)
#28 {main}
Impact

Deprecation warning.

Notes

Details

Request URL
https://www.mediawiki.org/w/index.php?title=*&action=reply&topic_postId=*
SubjectRepoBranchLines +/-
Fix deprecation warning from LinksUpdate::getImages()mediawiki/corewmf/1.38.0-wmf.18+1 -1
Correctly access ParserOutput::$mImagesmediawiki/extensions/GlobalUsagemaster+1 -1
Fix deprecation warning from LinksUpdate::getImages()mediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

jeena created this task.Jan 19 2022, 12:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2022, 12:08 AM
jeena added a parent task: T293960: 1.38.0-wmf.19 deployment blockers.Jan 19 2022, 12:09 AM
Zabe subscribed.Jan 19 2022, 12:11 AM
gerritbot added a comment.Jan 19 2022, 12:12 AM

Change 755049 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/GlobalUsage@master] Correctly access ParserOutput::$mImages

https://gerrit.wikimedia.org/r/755049

gerritbot added a project: Patch-For-Review.Jan 19 2022, 12:12 AM
gerritbot added a comment.Jan 19 2022, 4:13 AM

Change 755062 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Fix deprecation warning from LinksUpdate::getImages()

https://gerrit.wikimedia.org/r/755062

Krinkle assigned this task to • tstarling.Jan 19 2022, 4:18 AM
Krinkle added projects: Performance-Team, MediaWiki-Page-derived-data.
Krinkle moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.
gerritbot added a comment.Jan 19 2022, 4:35 AM

Change 755062 merged by jenkins-bot:

[mediawiki/core@master] Fix deprecation warning from LinksUpdate::getImages()

https://gerrit.wikimedia.org/r/755062

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 19 2022, 5:00 AM
gerritbot added a comment.Jan 19 2022, 10:07 AM

Change 755049 abandoned by Zabe:

[mediawiki/extensions/GlobalUsage@master] Correctly access ParserOutput::$mImages

Reason:

no longer necessary due to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/755062

https://gerrit.wikimedia.org/r/755049

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2022, 10:10 AM
gerritbot added a comment.Jan 20 2022, 12:39 PM

Change 755668 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Tim Starling):

[mediawiki/core@wmf/1.38.0-wmf.18] Fix deprecation warning from LinksUpdate::getImages()

https://gerrit.wikimedia.org/r/755668

gerritbot added a project: Patch-For-Review.Jan 20 2022, 12:39 PM
gerritbot added a comment.Jan 20 2022, 12:59 PM

Change 755668 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.18] Fix deprecation warning from LinksUpdate::getImages()

https://gerrit.wikimedia.org/r/755668

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.18; 2022-01-17); removed MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 20 2022, 1:00 PM
Stashbot added a comment.Jan 20 2022, 1:02 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-20T13:02:57Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.18/includes/deferred/LinksUpdate/LinksUpdate.php: Backport: [[gerrit:755668|Fix deprecation warning from LinksUpdate::getImages() (T299472)]] (duration: 00m 50s)

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2022, 1:10 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 20 2022, 1:38 PM
Lucas_Werkmeister_WMDE subscribed.

No new occurrences since Jan 20, 2022 @ 13:02:56.897, I think that’s enough to close this.

Screenshot 2022-01-20 at 14-37-49 mediawiki-errors - OpenSearch.png (220×678 px, 18 KB)

Lucas_Werkmeister_WMDE moved this task from Untriaged to Jan 2022 on the Wikimedia-production-error board.Jan 20 2022, 1:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL