[regression-wmf.18] Cannot read properties of undefined (reading 'length') - Flow pages are unresponsive
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

On group 0 wikis (testwiki, mediawiki) go to any Flow-enabled page, e.g. https://www.mediawiki.org/wiki/User_talk:Zilant13
The page has a spinning browser icon - a user cannot interact with the page
The following Console error is displayed:

Uncaught TypeError: Cannot read properties of undefined (reading 'length')
   at mwFlowUiTopicMenuSelectWidget.mw.flow.ui.TopicMenuSelectWidget.addItems (<anonymous>:345:210)
   at mwFlowUiTopicMenuSelectWidget.OoUiSelectWidget (load.php?lang=en&modules=ext.flow.templating|ext.wikiLove.init%2Cstartup|jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=1il0k:418:472)
   at mwFlowUiTopicMenuSelectWidget.OoUiMenuSelectWidget (load.php?lang=en&modules=ext.flow.templating|ext.wikiLove.init%2Cstartup|jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=1il0k:431:689)
   at new mwFlowUiTopicMenuSelectWidget (<anonymous>:342:340)
   at new mwFlowUiToCWidget (<anonymous>:346:82)
   at new mwFlowUiNavigationWidget (<anonymous>:349:203)
   at mw.flow.Initializer.setupNavigationWidget (<anonymous>:324:238)
   at mw.flow.Initializer.initializeWidgets (<anonymous>:321:774)
   at HTMLDocument.<anonymous> (<anonymous>:340:372)
   at mightThrow (load.php?lang=en&modules=ext.flow.templating|ext.wikiLove.init%2Cstartup|jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=1il0k:236:881)

Details

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.43.1	mediawiki/core	master	+3 K -1 K
Avoid calling .addItems() with undefined	oojs/ui	master	+8 -8
Fix TopicMenuSelectWidget after OOUI change	mediawiki/extensions/Flow	wmf/1.38.0-wmf.18	+5 -1
Fix TopicMenuSelectWidget after OOUI change	mediawiki/extensions/Flow	master	+5 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jeena	T293959 1.38.0-wmf.18 deployment blockers
		Resolved	BUG REPORT	kostajh	T299473 [regression-wmf.18] Cannot read properties of undefined (reading 'length') - Flow pages are unresponsive

Event Timeline

Etonkovidova created this task.Jan 19 2022, 12:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2022, 12:12 AM

Etonkovidova renamed this task from [regression-wmf.17] Cannot read properties of undefined (reading 'length') - Flow pages are unresponsive to [regression-wmf.18] Cannot read properties of undefined (reading 'length') - Flow pages are unresponsive.Jan 19 2022, 12:15 AM

Caused by rGOJU847f41a53629: Harden generic .addItems() methods in GroupElement and subclasses.

Change 755255 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/Flow@master] Fix TopicMenuSelectWidget after OOUI change

https://gerrit.wikimedia.org/r/755255

gerritbot added a project: Patch-For-Review.Jan 19 2022, 5:59 AM

Tgr triaged this task as Unbreak Now! priority.Jan 19 2022, 6:12 AM

Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Tgr added a parent task: T293959: 1.38.0-wmf.18 deployment blockers.

Tgr added a project: Wikimedia-production-error.Jan 19 2022, 6:15 AM

Tgr added a project: StructuredDiscussions.

Change 754921 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/Flow@wmf/1.38.0-wmf.18] Fix TopicMenuSelectWidget after OOUI change

https://gerrit.wikimedia.org/r/754921

Did a quick search, nothing else in our codebase seemed affected. There might be some less severe impact to VE (probably not a blocker?), left a note at https://gerrit.wikimedia.org/r/c/oojs/ui/+/748066/1#message-2e3e51bce4a1c306283658b7e7c98942507e2842

Stang subscribed.Jan 19 2022, 6:28 AM

Change 755255 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Fix TopicMenuSelectWidget after OOUI change

https://gerrit.wikimedia.org/r/755255

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 19 2022, 7:00 AM

Change 755316 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[oojs/ui@master] Avoid calling .addItems() with undefined

https://gerrit.wikimedia.org/r/755316

thiemowmde added a project: WMDE-TechWish-Maintenance.Jan 19 2022, 9:07 AM

thiemowmde subscribed.

Change 754921 merged by jenkins-bot:

[mediawiki/extensions/Flow@wmf/1.38.0-wmf.18] Fix TopicMenuSelectWidget after OOUI change

https://gerrit.wikimedia.org/r/754921

Mentioned in SAL (#wikimedia-operations) [2022-01-19T12:31:56Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.18/extensions/Flow/modules/flow/ui/widgets/mw.flow.ui.TopicMenuSelectWidget.js: Backport: [[gerrit:754921|Fix TopicMenuSelectWidget after OOUI change (T299473)]] (duration: 01m 08s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.18; 2022-01-17); removed MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 19 2022, 1:00 PM

Looks like a backport was done for this...is the issue resolved?
It looks like it to me according to the reproduction steps.

In T299473#7634070, @jeena wrote:

Looks like a backport was done for this...is the issue resolved?
It looks like it to me according to the reproduction steps.

Yes, all done!

Stang unsubscribed.Jan 19 2022, 8:30 PM

Change 755316 merged by jenkins-bot:

[oojs/ui@master] Avoid calling .addItems() with undefined

https://gerrit.wikimedia.org/r/755316

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2022, 3:10 AM

Krinkle moved this task from Untriaged to Jan 2022 on the Wikimedia-production-error board.Feb 4 2022, 12:47 AM

Change 761653 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Update OOUI to v0.43.1

https://gerrit.wikimedia.org/r/761653

gerritbot added a project: Patch-For-Review.Feb 10 2022, 3:37 PM

Change 761653 merged by jenkins-bot: