Page MenuHomePhabricator
Create Task
Maniphest T299475

Exception thrown in deep-list diff
Closed, ResolvedPublic
Actions

Description

See what @isaacl says at https://www.mediawiki.org/wiki/Topic:Woaaxnoga8w08n7x

Example: https://en.wikipedia.org/w/index.php?title=User:Isaacl/Visual_diff_test&diff=1066272389&oldid=1066272230&diffmode=visual

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (20902e538)mediawiki/extensions/VisualEditormaster+1 -1
Follow-up I9a67730: Pass current list node to appendListItemVisualEditor/VisualEditormaster+11 -1
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Jan 19 2022, 1:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2022, 1:12 AM
matmarex added subscribers: Esanders, matmarex.Jan 19 2022, 1:23 AM

git bisect tells me this broke in rGVED4b2339f6e878: List diff: Fix display of list node attribute change (e.g. bullet->numbered) (https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/748725)

matmarex added a project: VisualEditor.Jan 19 2022, 1:23 AM
Esanders updated the task description. (Show Details)Jan 19 2022, 1:42 AM
Esanders renamed this task from Visual diffs unhappy about getOuterRange to Exception thrown in deep-list diff.Jan 19 2022, 1:52 AM
gerritbot added a comment.Jan 19 2022, 1:57 AM

Change 755056 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up I9a67730: Pass current list node to appendListItem

https://gerrit.wikimedia.org/r/755056

gerritbot added a project: Patch-For-Review.Jan 19 2022, 1:57 AM
Esanders moved this task from Backlog to In progress on the VisualEditor-VisualDiffs board.Jan 19 2022, 1:58 AM
gerritbot added a comment.Jan 19 2022, 2:09 AM

Change 755056 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up I9a67730: Pass current list node to appendListItem

https://gerrit.wikimedia.org/r/755056

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2022, 2:10 AM
gerritbot added a comment.Jan 19 2022, 2:28 AM

Change 755058 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (20902e538)

https://gerrit.wikimedia.org/r/755058

gerritbot added a project: Patch-For-Review.Jan 19 2022, 2:28 AM
gerritbot added a comment.Jan 19 2022, 2:47 AM

Change 755058 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (20902e538)

https://gerrit.wikimedia.org/r/755058

matmarex added a project: Editing-team (Kanban Board).Jan 19 2022, 2:49 AM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
matmarex moved this task from Inbox to Low Priority on the Editing QA board.
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 19 2022, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 19 2022, 3:10 AM
EAkinloose subscribed.Jan 24 2022, 2:20 PM

This looks good now.
Console:

Screenshot 2022-01-24 at 15.20.01.png (305×1 px, 44 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Jan 24 2022, 2:21 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
• ppelberg closed this task as Resolved.Jan 29 2022, 1:33 AM
• ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL