Page MenuHomePhabricator

Add link to keyboard shortcuts to ? support pop-up
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

We added shortcuts, these need to be discoverable and reference-able (particularly in-context as users are working in the dialog). We are going to add the shortcuts to the existing VE shortcuts page, with a new section, and then link to there separately from the other help page.

Requirements

  • Add another quiet, progressive button to the existing support pop-up (accessed by the sticky, floating ? button). Icon: keyboard - Label: Keyboard shortcuts
  • Button links to new section on help page, in the UI language of the user (exact URL TBD after the content/section is added)

Question: hide button on mobile? The keyboard shortcuts aren't applicable on mobile but might still be useful to raise awareness of their existence and it's not really getting in the way on mobile.

Mock

Screen Shot 2022-01-21 at 11.03.30.png (686×768 px, 107 KB)

Event Timeline

ECohen_WMDE added a subscriber: Andrew-WMDE.

@Andrew-WMDE I know you started a patch for this, which is attached to T294521: Finishing touches on keyboard shortcuts in the new template dialog but I made this aspect a subticket. Can it be re-associated with this one?

ECohen_WMDE renamed this task from Add keyboard shortcuts to VE help screen to Add link to keyboard shortcuts to ? support pop-up.Jan 21 2022, 10:05 AM
ECohen_WMDE updated the task description. (Show Details)

Change 735592 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Add template shortcuts to VisualEditor's keyboard help dialog

https://gerrit.wikimedia.org/r/735592

Change 756020 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Link to a list of keyboard shortcuts from the template help dialog

https://gerrit.wikimedia.org/r/756020

Change 756020 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Link to a list of keyboard shortcuts from the template help dialog

https://gerrit.wikimedia.org/r/756020

thiemowmde set the point value for this task to 2.Jan 31 2022, 1:41 PM
thiemowmde moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-01-19 board.