Page MenuHomePhabricator

Clean up WikibaseContentLanguages and LanguageFallbackChainFactory service handling
Closed, ResolvedPublic

Description

WikibaseContentLanguages is currently being created from scratch in several places, especially in LanguageFallbackChainFactory, even though it should be available in the service container already. I’d like to clean that up, since T297393 might require injecting additional config into WikibaseContentLanguages (I’m not yet sure about that).

Event Timeline

Change 755433 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Get terms languages from services in entitytypes.php

https://gerrit.wikimedia.org/r/755433

Change 755434 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@master] Get WikibaseRepo term languages from services

https://gerrit.wikimedia.org/r/755434

Change 755439 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Inject terms languages into LanguageFallbackChainFactory

https://gerrit.wikimedia.org/r/755439

I’d like to clean that up, since T297393 might require injecting additional config into WikibaseContentLanguages (I’m not yet sure about that).

I ended up solving this differently, but I think these should still be nice cleanups, with some minor performance benefit too.

Change 755434 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Get WikibaseRepo term languages from services

https://gerrit.wikimedia.org/r/755434

Change 755433 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Get terms languages from services in entitytypes.php

https://gerrit.wikimedia.org/r/755433

Change 755439 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Inject terms languages into LanguageFallbackChainFactory

https://gerrit.wikimedia.org/r/755439