Page MenuHomePhabricator

Update button in confirmation dialog
Closed, ResolvedPublic2 Estimated Story Points


As a follow-up to T297792: Warning before losing changes to template in VE dialog we've decided to update a few aspects to make it clearer, especially for the users who glance at it quickly without reading through. This also makes it a bit more consistent with the confirmation before losing changes when leaving VE as a whole (ex. switching from edit to read tab after making changes).


  • Change label of both "Close" and "Go back" buttons to Discard edits
  • Change both buttons to the normal destructive type


Both are shown with right hand button focused.

Close - confirmation.png (715×1 px, 129 KB)
Back - confirmation.png (715×1 px, 128 KB)

Event Timeline

ECohen_WMDE renamed this task from Confirmation/warning about closing dialog - update button to Update button in confirmation dialog.Jan 21 2022, 10:57 AM

Change 755980 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Update accept button in confirmation dialog

WMDE-Fisch set the point value for this task to 2.Jan 21 2022, 2:16 PM
WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-01-19 board.

Change 755980 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update accept button in confirmation dialog

thiemowmde moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-01-19 board.