Trying to lock+suppress any global account fails and returns the following error message:
Sorry! This site is experiencing technical difficulties. Try waiting a few minutes and reloading. (Cannot access the database: Cannot access the database: Unknown database 'metawiki' (db1175) (db1175))
This impacts the stewards' ability to suppress abusive usernames that are outing or harassing (as it was the case when I discovered this bug).
Thank you.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| DatabaseBlock: fetch a database connection for the correct wiki | mediawiki/core | master | +62 -9 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Security | • Pchelolo | T281972 ActorStore::checkDatabaseDomain: InvalidArgumentException: DB connection domain does not match when suppressing via Special:CentralAuth (CVE-2021-36128) | ||
| Resolved | Security | Zabe | T284873 Regression: CentralAuth Lock+Suppress is issuing local blocks without autoblock | ||
| Open | None | T291994 Properly support cross-wiki blocking | |||
| Resolved | Zabe | T274817 Convert DatabaseBlock and AbstractBlock to UserIdentity, and make them cross-wiki aware. | |||
| Resolved | Release | brennen | T293960 1.38.0-wmf.19 deployment blockers | ||
| Resolved | Security | Zabe | T299655 [regression] Cannot globally suppress any global account |
Adding DBA due to the error message. Which is really odd since the rest of metawiki (that I can see) seems fine.
That's not an issue with DBAs, it's a mess in CA connecting to the wrong database but I'm helping here given the severity.
Consensus on _security seems to be revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/723790 in wmf.18 only and fix the tests (possibly https://gerrit.wikimedia.org/r/c/mediawiki/core/+/755725/) in wmf.19.
As far as I can see the two logged suppressions (not naming accounts here on purpose to avoid this being PermanentlyPrivate) after wmf.18 was have promoted completed successfully instead of being in some weird half-suppressed state.
I can lock and suppress accounts via CentralAuth again in production. Thanks to all for your swift action and response to this incident.
I'm going to make this public now as the issue was resolved with the revert in gerrit and deployed.
Change 755758 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] DatabaseBlock: fetch a database connection for the correct wiki
For clarity, the actual revert of https://gerrit.wikimedia.org/r/723790 that landed on wmf.18 and was deployed:
Change 755758 merged by jenkins-bot:
[mediawiki/core@master] DatabaseBlock: fetch a database connection for the correct wiki