bold-f icon is too small
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Jan 20 2022, 4:32 PM

Description

Character is only 14px high, the other Latin variants are 18px:

Details

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.43.1	mediawiki/core	master	+3 K -1 K
	icons: Further optimize 'bold' and 'italic' icons and update 'bold-f'	oojs/ui	master	+30 -29

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Volker_E	T298211 WikimediaUI: Icons for bold and italics beyond English defaults not aligned to icon guidelines
		Resolved		Volker_E	T299660 bold-f icon is too small

Event Timeline

Esanders created this task.Jan 20 2022, 4:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2022, 4:32 PM

Related to T298211. The (ar) variant looks a little small too.

Looks like bold-f.svg and bold-arab-ain.svg didn't make it into this patch: https://gerrit.wikimedia.org/r/c/oojs/ui/+/753172

The codex patch is also missing those files: https://gerrit.wikimedia.org/r/c/design/codex/+/753174

Volker_E added a parent task: T298211: WikimediaUI: Icons for bold and italics beyond English defaults not aligned to icon guidelines.Jan 25 2022, 4:16 PM

Change 758045 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] icons: Further optimize 'bold*' and 'italic*' icons and update 'bold-f'

https://gerrit.wikimedia.org/r/758045

gerritbot added a project: Patch-For-Review.Jan 29 2022, 3:50 PM

Change 758045 merged by jenkins-bot:

[oojs/ui@master] icons: Further optimize 'bold*' and 'italic*' icons and update 'bold-f'

https://gerrit.wikimedia.org/r/758045

bold-f before and after visualised:
https://github.com/wikimedia/oojs-ui/commit/59ca9e2e89ebbc7dc53c29a2c05d75d593786497?short_path=1c9abb8#diff-1c9abb86a1ebc9ac5446103ba53341ab68daf2e7766e31648e1f0eca5fc3efe6

Screenshot 2022-01-30 at 02.39.09.png (140×286 px, 8 KB)

I found the italic-arab-teh changed notably as well, assumed intentional but here for the record:

https://github.com/wikimedia/oojs-ui/commit/59ca9e2e89ebbc7dc53c29a2c05d75d593786497?short_path=3c30683#diff-3c30683da870f024ad8647d99fe8413fde5a1d56364f953399bc61ff92cd3918

Screenshot 2022-01-30 at 02.39.44.png (143×235 px, 9 KB)

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2022, 3:10 AM

In T299660#7661885, @Krinkle wrote:

I found the italic-arab-teh changed notably as well, assumed intentional but here for the record:

https://github.com/wikimedia/oojs-ui/commit/59ca9e2e89ebbc7dc53c29a2c05d75d593786497?short_path=3c30683#diff-3c30683da870f024ad8647d99fe8413fde5a1d56364f953399bc61ff92cd3918

That's right, that was a second miss from the first overhaul and got already part of Codex.
The WikimediaUI icons Figma file is the source of truth and has had it included 12 days ago as part of parent task.

Volker_E closed this task as Resolved.Jan 30 2022, 1:05 PM

Volker_E claimed this task.

Volker_E triaged this task as Medium priority.

Volker_E moved this task from Backlog to OOUI-0.43.1 on the OOUI board.

Volker_E edited projects, added OOUI (OOUI-0.43.1); removed OOUI.

Change 761653 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Update OOUI to v0.43.1

https://gerrit.wikimedia.org/r/761653

gerritbot added a project: Patch-For-Review.Feb 10 2022, 3:37 PM

Change 761653 merged by jenkins-bot: