Page MenuHomePhabricator

Reference with invalid groups can't be edited
Closed, ResolvedPublic

Description

Create a reference in source mode with a group that doesn't have a corresponding references list

<ref group="foo">Bar</ref>

Open this in VE and notice that it is no longer treated as a reference node. This is due to it being given an mw:Error RDFa attribute.

Actual:

image.png (88×427 px, 3 KB)

Expected:

image.png (120×421 px, 4 KB)

Event Timeline

Change 755739 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/Cite@master] ve-cite: Handle ref nodes with mw:Error RDFa

https://gerrit.wikimedia.org/r/755739

Change 755739 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] ve-cite: Handle ref nodes with mw:Error RDFa

https://gerrit.wikimedia.org/r/755739

matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
matmarex moved this task from Inbox to Low Priority on the Editing QA board.

This is now rightly treated as a reference node.
As expected, see:

Screenshot 2022-01-24 at 15.25.13.png (289×594 px, 23 KB)

ppelberg claimed this task.