Some headings are missing on the main page on Meta-Wiki in Parsoid rendering
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	matmarex
	Jan 20 2022, 7:10 PM

Description

Some of the headings on the main page on Meta-Wiki have no content in the Parsoid HTML.

Normal read mode	Parsoid HTML
https://meta.wikimedia.org/wiki/Main_Page	https://meta.wikimedia.org/api/rest_v1/page/html/Main_Page

(reported in T299583)

Details

	Subject	Repo	Branch	Lines +/-
	Strip annotations from template arguments	mediawiki/services/parsoid	master	+448 -322

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Open		None	T258838 [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid
Open		None	T351374 Improve Translatable Pages based on research input
Open		None	T131516 Reduce or eliminate the need for the user to touch <translate> tags and unit markers
Open		None	T143327 Make the Translate extension be based on DOM, not strings
Resolved		Esanders	T73730 VisualEditor: Content inside templates for translation of templates does not render in friendly ways
Open	Feature	None	T55974 Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension)
Resolved		ihurbain	T261172 Much content is missing when editing a translatable page
Resolved		ihurbain	T261181 Make Translate extension compatible with Parsoid
Resolved	BUG REPORT	Arlolra	T299685 Some headings are missing on the main page on Meta-Wiki in Parsoid rendering
Resolved		ihurbain	T295834 Add special handling for annotation tags in template arguments
Resolved	BUG REPORT	ihurbain	T296392 Old syntax tvar breaks templates

Event Timeline

matmarex created this task.Jan 20 2022, 7:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2022, 7:10 PM

matmarex mentioned this in T299583: Wikimedia\Assert\PreconditionException: Precondition failed: Range is not collapsed.Jan 20 2022, 7:20 PM

The wikitext contains

{{ Template:Main Page/WM News
  | lang = <translate><!--T:15--> en</translate> | dir = {{dir|{{int:lang}}}}<!-- TO BE MIGRATED -->
}}

Probably the <translate> tags are not removed, and they cause issues in {{LangSwitch}}. Actually, this translation unit shouldn’t be there in the first place, the above code block should be replaced by {{Main Page/WM News|lang={{PAGELANGUAGE}}}} to avoid translators doing unnecessary work and breaking the output with the legacy parser as well.

Tacsipacsi added a parent task: T261181: Make Translate extension compatible with Parsoid.Jan 21 2022, 9:54 PM

T295834: Add special handling for annotation tags in template arguments is related and might solve this if @Tacsipacsi's analysis is correct (we haven't yet looked at this).

ihurbain subscribed.Jan 24 2022, 1:05 PM

Arlolra triaged this task as Medium priority.Feb 2 2022, 6:25 PM

Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.

Arlolra added a subtask: T295834: Add special handling for annotation tags in template arguments.

Change 737825 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] Strip annotations seen in template arguments for now

https://gerrit.wikimedia.org/r/737825

gerritbot added a project: Patch-For-Review.Feb 8 2022, 5:26 PM

ssastry added a project: Parsoid-Read-Views (Phase 2 - testwiki Main namespace support).Feb 8 2022, 10:10 PM

This was fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/762849

The patch in T299685#7694120 is on hold

Change 737825 abandoned by Subramanya Sastry:

[mediawiki/services/parsoid@master] Strip annotations from template arguments

Reason:

We can revisit this at a later time. Abandoning for now.

https://gerrit.wikimedia.org/r/737825

Maintenance_bot removed a project: Patch-For-Review.Mar 14 2022, 5:10 PM

ihurbain closed subtask T295834: Add special handling for annotation tags in template arguments as Resolved.Jan 12 2023, 9:44 AM

Some headings are missing on the main page on Meta-Wiki in Parsoid renderingClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Some headings are missing on the main page on Meta-Wiki in Parsoid rendering
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...