Page MenuHomePhabricator
Create Task
Maniphest T299685

Some headings are missing on the main page on Meta-Wiki in Parsoid rendering
Closed, ResolvedPublicBUG REPORT
Actions

Description

Some of the headings on the main page on Meta-Wiki have no content in the Parsoid HTML.

Normal read modeParsoid HTML
https://meta.wikimedia.org/wiki/Main_Pagehttps://meta.wikimedia.org/api/rest_v1/page/html/Main_Page
image.png (2×3 px, 550 KB)
image.png (2×3 px, 476 KB)

(reported in T299583)

Details

ProjectBranchLines +/-Subject
mediawiki/services/parsoidmaster+448 -322Strip annotations from template arguments
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 OpenNoneT258838 [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid
 OpenNoneT131516 Reduce or eliminate the need for the user to touch <translate> tags and unit markers
 OpenNoneT143327 Make the Translate extension be based on DOM, not strings
 ResolvedEsandersT73730 VisualEditor: Content inside templates for translation of templates does not render in friendly ways
 OpenFeatureNoneT55974 Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension)
 ResolvedihurbainT261172 Much content is missing when editing a translatable page
 OpenihurbainT261181 Make Translate extension compatible with Parsoid
 ResolvedBUG REPORTArlolraT299685 Some headings are missing on the main page on Meta-Wiki in Parsoid rendering
 ResolvedihurbainT295834 Add special handling for annotation tags in template arguments
 OpenBUG REPORTihurbainT296392 Old syntax tvar breaks templates

Event Timeline

matmarex created this task.Jan 20 2022, 7:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2022, 7:10 PM
matmarex mentioned this in T299583: Wikimedia\Assert\PreconditionException: Precondition failed: Range is not collapsed.Jan 20 2022, 7:20 PM
Tacsipacsi changed the subtype of this task from "Task" to "Bug Report".Jan 21 2022, 9:54 PM
Tacsipacsi added a subscriber: Tacsipacsi.

The wikitext contains

{{ Template:Main Page/WM News
  | lang = <translate><!--T:15--> en</translate> | dir = {{dir|{{int:lang}}}}<!-- TO BE MIGRATED -->
}}

Probably the <translate> tags are not removed, and they cause issues in {{LangSwitch}}. Actually, this translation unit shouldn’t be there in the first place, the above code block should be replaced by {{Main Page/WM News|lang={{PAGELANGUAGE}}}} to avoid translators doing unnecessary work and breaking the output with the legacy parser as well.

Tacsipacsi added a parent task: T261181: Make Translate extension compatible with Parsoid.Jan 21 2022, 9:54 PM
ssastry added a subscriber: ssastry.Jan 21 2022, 10:04 PM

T295834: Add special handling for annotation tags in template arguments is related and might solve this if @Tacsipacsi's analysis is correct (we haven't yet looked at this).

ihurbain added a subscriber: ihurbain.Jan 24 2022, 1:05 PM
Arlolra triaged this task as Medium priority.Feb 2 2022, 6:25 PM
Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
Arlolra added a subtask: T295834: Add special handling for annotation tags in template arguments.
gerritbot added a comment.Feb 8 2022, 5:26 PM

Change 737825 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] Strip annotations seen in template arguments for now

https://gerrit.wikimedia.org/r/737825

gerritbot added a project: Patch-For-Review.Feb 8 2022, 5:26 PM
ssastry added a project: Parsoid-Read-Views (Phase 2 - testwiki Main namespace support).Feb 8 2022, 10:10 PM
Arlolra closed this task as Resolved.Mar 10 2022, 10:00 PM
Arlolra claimed this task.
Arlolra added a subscriber: Arlolra.

This was fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/762849

The patch in T299685#7694120 is on hold

gerritbot added a comment.Mar 14 2022, 5:01 PM

Change 737825 abandoned by Subramanya Sastry:

[mediawiki/services/parsoid@master] Strip annotations from template arguments

Reason:

We can revisit this at a later time. Abandoning for now.

https://gerrit.wikimedia.org/r/737825

Maintenance_bot removed a project: Patch-For-Review.Mar 14 2022, 5:10 PM
ihurbain closed subtask T295834: Add special handling for annotation tags in template arguments as Resolved.Jan 12 2023, 9:44 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL