Memcached::cas(): Argument #4 ($expiration) must be of type int, int given
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Jan 20 2022, 8:03 PM

Description

[5593d0f06d04e8ac8fc9c52a] [no req]   TypeError: Memcached::cas(): Argument #4 ($expiration) must be of type int, int given
Backtrace:
from /var/www/wiki/mediawiki/core/includes/libs/objectcache/MemcachedPeclBagOStuff.php(227)
#0 /var/www/wiki/mediawiki/core/includes/libs/objectcache/MemcachedPeclBagOStuff.php(227): Memcached->cas()
#1 /var/www/wiki/mediawiki/core/includes/libs/objectcache/MediumSpecificBagOStuff.php(357): MemcachedPeclBagOStuff->doCas()
#2 /var/www/wiki/mediawiki/core/includes/libs/objectcache/MediumSpecificBagOStuff.php(318): MediumSpecificBagOStuff->cas()
#3 /var/www/wiki/mediawiki/core/includes/libs/objectcache/MediumSpecificBagOStuff.php(270): MediumSpecificBagOStuff->mergeViaCas()
#4 /var/www/wiki/mediawiki/core/includes/libs/objectcache/wancache/WANObjectCache.php(905): MediumSpecificBagOStuff->merge()
#5 /var/www/wiki/mediawiki/core/includes/cache/MessageCache.php(877): WANObjectCache->set()
#6 /var/www/wiki/mediawiki/core/includes/cache/MessageCache.php(816): MessageCache->setValidationHash()
#7 /var/www/wiki/mediawiki/core/includes/cache/MessageCache.php(442): MessageCache->saveToCaches()
#8 /var/www/wiki/mediawiki/core/includes/cache/MessageCache.php(363): MessageCache->loadFromDBWithLock()
#9 /var/www/wiki/mediawiki/core/includes/cache/MessageCache.php(1103): MessageCache->load()
#10 /var/www/wiki/mediawiki/core/includes/cache/MessageCache.php(1031): MessageCache->getMsgFromNamespace()
#11 /var/www/wiki/mediawiki/core/includes/cache/MessageCache.php(1002): MessageCache->getMessageForLang()
#12 /var/www/wiki/mediawiki/core/includes/cache/MessageCache.php(944): MessageCache->getMessageFromFallbackChain()
#13 /var/www/wiki/mediawiki/core/includes/language/Message.php(1455): MessageCache->get()
#14 /var/www/wiki/mediawiki/core/includes/language/Message.php(945): Message->fetchMessage()
#15 /var/www/wiki/mediawiki/core/includes/language/Message.php(1035): Message->format()
#16 /var/www/wiki/mediawiki/extensions/AbuseFilter/includes/Hooks/Handlers/SchemaChangesHandler.php(145): Message->text()
#17 /var/www/wiki/mediawiki/core/includes/installer/DatabaseUpdater.php(533): MediaWiki\Extension\AbuseFilter\Hooks\Handlers\SchemaChangesHandler->createAbuseFilterUser()
#18 /var/www/wiki/mediawiki/core/includes/installer/DatabaseUpdater.php(501): DatabaseUpdater->runUpdates()
#19 /var/www/wiki/mediawiki/core/maintenance/update.php(193): DatabaseUpdater->doUpdates()
#20 /var/www/wiki/mediawiki/core/maintenance/doMaintenance.php(108): UpdateMediaWiki->execute()
#21 /var/www/wiki/mediawiki/core/maintenance/update.php(264): require_once(string)
#22 {main}

Related Objects

Mentioned In: T248925: Make MediaWiki release tarball compatible with PHP 8.0
T299312: Deprecated: CLASS implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary)

Event Timeline

Reedy created this task.Jan 20 2022, 8:03 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptJan 20 2022, 8:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.Jan 20 2022, 8:15 PM

Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.Jan 21 2022, 6:17 PM

Krinkle moved this task from libs/objectcache to General on the MediaWiki-libs-BagOStuff board.Jan 22 2022, 11:24 PM

• dpifke assigned this task to aaron.Jan 24 2022, 7:37 PM

• dpifke moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.

That's an odd error message, is that reproducible?

There is this commit in the php-memcached repo which may be related: https://github.com/php-memcached-dev/php-memcached/commit/51c9baf49f96c5f35be8257549f426ef1860f0ef

In T299693#7646527, @tstarling wrote:

That's an odd error message, is that reproducible?

Yeah. Every time I run update.php on PHP 8.1 (I only did it accidentally before) it's the last thing output (after a spew of other errors, deprecations etc)

$ php8.1 -v
PHP 8.1.1 (cli) (built: Dec 31 2021 07:26:56) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.1, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.1, Copyright (c), by Zend Technologies
    with Xdebug v3.1.2, Copyright (c) 2002-2021, by Derick Rethans

Mostly using 8.1.1-2+ubuntu21.10.1+deb.sury.org+1

Reedy mentioned this in T299312: Deprecated: CLASS implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary).Jan 25 2022, 11:09 AM

I was able to reproduce the bug and confirm that the commit I linked to fixes it.

Guess we're waiting on upstream to make a new release then? https://github.com/php-memcached-dev/php-memcached/compare/v3.1.5...master

People are begging for a release to fix this issue at https://github.com/php-memcached-dev/php-memcached/issues/496

taavi subscribed.Jan 29 2022, 2:03 PM

Reedy removed aaron as the assignee of this task.Jan 29 2022, 5:01 PM

Reedy added a subscriber: aaron.

Reedy moved this task from Backlog to Patch merged upstream on the Upstream board.Feb 8 2022, 3:23 PM

Reedy mentioned this in T248925: Make MediaWiki release tarball compatible with PHP 8.0.Feb 19 2022, 5:27 PM

Progress!

https://github.com/php-memcached-dev/php-memcached/issues/496#issuecomment-1062995069

memcached 3.2.0RC1 and 3.2.0RC2 have been released today. I assume this ticket can be closed.

https://github.com/php-memcached-dev/php-memcached/releases/tag/v3.2.0

Krinkle closed this task as Resolved.May 24 2022, 6:32 PM

Krinkle assigned this task to aaron.

Memcached::cas(): Argument #4 ($expiration) must be of type int, int givenClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Memcached::cas(): Argument #4 ($expiration) must be of type int, int given
Closed, ResolvedPublic
Actions