Page MenuHomePhabricator
Create Task
Maniphest T299698

Move out transaction management out of Database class
Closed, ResolvedPublic
Actions

Description

This includes a complex logic of handling transactions. It really doesn't need to be there.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
rdbms: Move more internal code from Database to TransactionManagermediawiki/coremaster+110 -73
rdbms: Simplify TransactionManager class a bit now the code has movedmediawiki/coremaster+94 -97
rdbms: Move transaction callbacks out of Database to TransactionManagermediawiki/coremaster+320 -236
rdbms: Migrate TransactionProfiler calls to TransactionManagermediawiki/coremaster+51 -44
rdbms: Move another batch of transaction management codemediawiki/coremaster+61 -49
rdbms: Migrate $this->trxFname to TransactionManagermediawiki/coremaster+38 -25
rdbms: Move more code from Database to TransactionManagermediawiki/coremaster+276 -182
rdbms: Move write transaction reporting to TransactionManagermediawiki/coremaster+110 -90
rdbms: Introduce TransactionManager class to move out the logicmediawiki/coremaster+99 -27
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Jan 20 2022, 8:29 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 20 2022, 8:29 PM
gerritbot added a comment.Jan 20 2022, 8:31 PM

Change 755786 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Introduce TransactionManager class to move out the logic

https://gerrit.wikimedia.org/r/755786

gerritbot added a project: Patch-For-Review.Jan 20 2022, 8:31 PM
Ladsgroup triaged this task as Medium priority.Jan 20 2022, 8:32 PM
Ladsgroup moved this task from Triage to In progress on the DBA board.
Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Jan 24 2022, 7:24 PM
Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.Jan 26 2022, 8:16 PM
gerritbot added a comment.Jan 28 2022, 7:17 PM

Change 755786 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Introduce TransactionManager class to move out the logic

https://gerrit.wikimedia.org/r/755786

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 28 2022, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 28 2022, 8:10 PM
gerritbot added a comment.Jan 28 2022, 10:05 PM

Change 757984 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Move more code from Database to TransactionManager

https://gerrit.wikimedia.org/r/757984

gerritbot added a project: Patch-For-Review.Jan 28 2022, 10:05 PM
gerritbot added a comment.Feb 5 2022, 5:12 AM

Change 757984 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Move more internal code from Database to TransactionManager

https://gerrit.wikimedia.org/r/757984

ReleaseTaggerBot edited projects, added: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07); removed: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Feb 5 2022, 6:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 5 2022, 6:10 AM
gerritbot added a comment.Feb 7 2022, 9:21 PM

Change 760664 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Move write transaction reporting to TransactionManager

https://gerrit.wikimedia.org/r/760664

gerritbot added a project: Patch-For-Review.Feb 7 2022, 9:21 PM
gerritbot added a comment.Feb 9 2022, 4:47 AM

Change 760664 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Move write transaction reporting to TransactionManager

https://gerrit.wikimedia.org/r/760664

ReleaseTaggerBot edited projects, added: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14); removed: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 9 2022, 5:00 AM
gerritbot added a comment.Feb 14 2022, 1:03 PM

Change 762436 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Move more code from Database to TransactionManager

https://gerrit.wikimedia.org/r/762436

gerritbot added a comment.Feb 16 2022, 12:57 PM

Change 762436 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Move more code from Database to TransactionManager

https://gerrit.wikimedia.org/r/762436

ReleaseTaggerBot edited projects, added: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21); removed: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 16 2022, 1:00 PM
gerritbot added a comment.Feb 21 2022, 2:03 AM

Change 763964 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Migrate $this->trxFname to TransactionManager

https://gerrit.wikimedia.org/r/763964

gerritbot added a comment.Feb 21 2022, 5:31 PM

Change 763964 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Migrate $this->trxFname to TransactionManager

https://gerrit.wikimedia.org/r/763964

gerritbot added a comment.Feb 22 2022, 3:49 AM

Change 764466 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Move another batch of transaction management code

https://gerrit.wikimedia.org/r/764466

gerritbot added a comment.Feb 25 2022, 11:51 AM

Change 764466 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Move another batch of transaction management code

https://gerrit.wikimedia.org/r/764466

ReleaseTaggerBot edited projects, added: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28); removed: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 25 2022, 12:00 PM
gerritbot added a comment.Feb 25 2022, 7:55 PM

Change 766188 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Migrate TransactionProfiler calls to TransactionManager

https://gerrit.wikimedia.org/r/766188

gerritbot added a comment.Mar 3 2022, 8:20 PM

Change 766188 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Migrate TransactionProfiler calls to TransactionManager

https://gerrit.wikimedia.org/r/766188

ReleaseTaggerBot edited projects, added: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07); removed: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Mar 3 2022, 9:00 PM
gerritbot added a comment.Mar 4 2022, 7:47 AM

Change 768004 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Move transaction callbacks out of Database to TransactionManager

https://gerrit.wikimedia.org/r/768004

gerritbot added a comment.Mar 4 2022, 11:49 PM

Change 768004 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Move transaction callbacks out of Database to TransactionManager

https://gerrit.wikimedia.org/r/768004

gerritbot added a comment.Mar 7 2022, 5:30 AM

Change 768366 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Simplify TransactionManager class a bit now the code has moved

https://gerrit.wikimedia.org/r/768366

gerritbot added a comment.Mar 7 2022, 4:16 PM

Change 768366 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Simplify TransactionManager class a bit now the code has moved

https://gerrit.wikimedia.org/r/768366

Ladsgroup closed this task as Resolved.Mar 7 2022, 4:28 PM
Ladsgroup moved this task from In progress to Done on the DBA board.
Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Mar 7 2022, 5:15 PM
Jdforrester-WMF mentioned this in T299691: Break down monster class: Database.Aug 5 2022, 8:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits