Page MenuHomePhabricator

VE: Elements placed in bulleted list (* or #) aren't editable by mouse
Closed, ResolvedPublicBUG REPORT

Description

Elements (comments/templates/references) placed in bulleted list (* or #) aren't editable by mouse

Bug report for reference(s):

List of steps to reproduce (step by step, including full links if applicable):

  • In VisualEditor (VE), paste:
<ref>test0</ref>
# <ref>test1</ref>
* <ref>test2</ref>
<ref>test3</ref>

(or edit https://pl.wikipedia.org/wiki/Wikipedysta:MarMi_wiki/test_ref_point in VE)

  • Try to edit [2] (test1) and [3] (test2)

What happens?:
[2] (test1) and [3] (test2) aren't editable (the edit dialog doesn't show up if you click on the ref. You can still use arrow keys to get to the edit dialog)

What should have happened instead?:
[2] (test1) and [3] (test2) should be editable, like [1] (test0) and [4] (test3)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
On pl (https://pl.wikipedia.org/wiki/Noj_Giter-Granatsztajn#Publikacje) and en versions of Wikipedia (at least, didn't checked the others).

Additionally, if you carefully hover over the top of reference box ([1]/test0 or [4]/test3), mouse pointer changes to a hand - and if you click, page will scroll to the beginning of edited article (if edited article takes more than one screen page).

Event Timeline

MarMi_wiki renamed this task from VE: References in bullet points aren't editable to VE: References in bullet points doesn't open the ref edit dialog (mouse).Jan 21 2022, 6:21 PM
MarMi_wiki updated the task description. (Show Details)
MarMi_wiki renamed this task from VE: References in bullet points doesn't open the ref edit dialog (mouse) to VE: Elements placed in bulleted list aren't editable by mouse.Jan 21 2022, 11:33 PM
MarMi_wiki renamed this task from VE: Elements placed in bulleted list aren't editable by mouse to VE: Elements placed in bulleted list (* or #) aren't editable by mouse.
MarMi_wiki updated the task description. (Show Details)
MarMi_wiki updated the task description. (Show Details)

Note that this also affects templates. You cannot edit any template within a list, at least not with a mouse. Same problem with touch screen.

Workaround: Place your cursor beside a template and use your keyboard (arrow keys) to open a popup for the template. Same for references.

Change 756582 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756582

Change 756582 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756582

Change 756584 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@wmf/1.38.0-wmf.18] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756584

Change 756640 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6282889f4)

https://gerrit.wikimedia.org/r/756640

Change 756584 merged by jenkins-bot:

[VisualEditor/VisualEditor@wmf/1.38.0-wmf.18] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756584

Change 756650 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Update VE core submodule to origin/wmf/1.38.0-wmf.18

https://gerrit.wikimedia.org/r/756650

Change 756650 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Update VE core submodule to origin/wmf/1.38.0-wmf.18

https://gerrit.wikimedia.org/r/756650

Mentioned in SAL (#wikimedia-operations) [2022-01-24T19:47:03Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.18/extensions/VisualEditor/lib/ve/: a369e0a: Revert "Follow-up I0802440d9: Allow alien <tr>/<td> s to be focused" (deployed via e09d79d; T298609; T299730) (duration: 00m 49s)

Change 756640 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6282889f4)

https://gerrit.wikimedia.org/r/756640

matmarex moved this task from Doing to QA on the Editing-team (FY2021-22 Kanban Board) board.
matmarex edited projects, added Editing QA; removed Patch-For-Review.

This should be resolved everywhere now. Sorry about that…

The bug was caused by a patch that was meant to improve some interactions with table rows and cell that are generated using templates (T298609). Right now I don't know why it broke in this way, we'll document it on that task when we figure it out.

Change 756719 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up I227a0d70: Remove partially complete mixin of ContentEditableNode from list items

https://gerrit.wikimedia.org/r/756719

It looks like the patch exposed some broken code that had been lying in wait for a few years. The patch above should fix the issue.

It looks like the patch exposed some broken code that had been lying in wait for a few years. The patch above should fix the issue.

Does the above need backported to wmf.19?

If I'm reading things correctly, the answer here is no - sorry, just getting my bearings for the train. Removing as a blocker; please re-add if I'm mistaken.

Change 756719 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up I227a0d70: Remove partially complete mixin of ContentEditableNode from list items

https://gerrit.wikimedia.org/r/756719

Change 757074 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbdba097b)

https://gerrit.wikimedia.org/r/757074

Change 757074 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbdba097b)

https://gerrit.wikimedia.org/r/757074