Page MenuHomePhabricator

Deprecated: Use of ParserOutput::addModules with non-array argument was deprecated
Closed, ResolvedPublic

Description

Seen on https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/48/console from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/755846

09:51:29 Deprecated: Use of ParserOutput::addModules with non-array argument was deprecated in MediaWiki 1.38. [Called from ParserOutputTest::provideMergeHtmlMetaDataFrom in /workspace/src/tests/phpunit/includes/parser/ParserOutputTest.php at line 597] in /workspace/src/includes/debug/MWDebug.php on line 377
09:51:29 
09:51:29 Deprecated: Use of ParserOutput::addModuleStyles with non-array argument was deprecated in MediaWiki 1.38. [Called from ParserOutputTest::provideMergeHtmlMetaDataFrom in /workspace/src/tests/phpunit/includes/parser/ParserOutputTest.php at line 598] in /workspace/src/includes/debug/MWDebug.php on line 377

Looks like it was deprecated without the callers in ParserOutputTest::provideMergeHtmlMetaDataFrom being updated?

Deprecation was done in rMW75480cf1e035: Narrow the signature of ParserOutput::addModules() and ::addModuleStyles() by @cscott

Event Timeline

Reedy updated the task description. (Show Details)
Reedy added a subscriber: cscott.

Change 755946 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] ParserOutputTest: Call ParserOutput::addModule(Style)?s with an array

https://gerrit.wikimedia.org/r/755946

Change 755946 merged by jenkins-bot:

[mediawiki/core@master] ParserOutputTest: Call ParserOutput::addModule(Style)?s with an array

https://gerrit.wikimedia.org/r/755946

Reedy claimed this task.