Page MenuHomePhabricator

When using VE section edit link on desktop, scroll selected heading to top of page while opening editor
Closed, ResolvedPublic

Description

After clicking on a section edit link, we show a loading bar but do nothing else. When the editor finishes loading we scroll the heading to the top of the page instantly.

On mobile there is a smooth scroll bringing the heading to the top of the page so there is no jump when the editor finishes loading.

We should copy this behaviour to desktop for the same reasons we implemented it on mobile.

This would not apply when the page-level edit link from the sticky header is used, so that feature (T296910) would remain unchanged.

Event Timeline

Change 756134 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Smooth scroll the heading to the right place while target is loading

https://gerrit.wikimedia.org/r/756134

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/d812f22670/w/

Per yesterday's conversations with @Esanders and @iamjessklein, what Ed implemented in the demo above looks great. Let's deploy it.

Change 756134 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Smooth scroll the heading to the right place while target is loading

https://gerrit.wikimedia.org/r/756134

matmarex added a project: Editing QA.
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
ppelberg claimed this task.

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d812f22670/w/