Page MenuHomePhabricator

Consolidate ext.growthExperiments.Homepage.ConfirmEmail.styles
Closed, ResolvedPublic

Description

This is used to style the notice on the homepage telling the user that their email addressed has been confirmed (Special:Homepage?source=specialconfirmemail). The styles can be included in ext.growthExperiments.Homepage.styles instead.

Currently ext.growthExperiments.Homepage.ConfirmEmail/ConfirmEmail.less is centering the notification area .mw-notification-area. When the file is bundled with other homepage styles, this logic should be updated so that the change only impacts the email confirmation notification and not all notifications.

Event Timeline

Change 756093 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Consolidate ext.growthExperiments.Homepage.ConfirmEmail.styles into ext.growthExperiments.Homepage.styles

https://gerrit.wikimedia.org/r/756093

With JSNo JSRegular notification
Desktop
confirmEmailNotice_dt-js.png (1×2 px, 1 MB)
confirmEmailNotice_dt-nojs.png (1×2 px, 901 KB)
Screen Shot 2022-01-21 at 2.55.33 PM.png (1×2 px, 1 MB)
Mobile
confirmEmailNotice_mobile-js.png (1×656 px, 116 KB)
confirmEmailNotice_mobile-nojs.png (1×650 px, 105 KB)
Untitled.jpg (1×641 px, 79 KB)

Change 756093 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Consolidate ext.growthExperiments.Homepage.ConfirmEmail.styles into ext.growthExperiments.Homepage.styles

https://gerrit.wikimedia.org/r/756093

Etonkovidova subscribed.

Checked on testwiki wmf.21 - all works as expected (the email confirmation is somewhat smaller though- the screenshot are done with 100% scale):

Screen Shot 2022-02-10 at 5.59.50 PM.png (826×2 px, 213 KB)
Screen Shot 2022-02-10 at 6.00.33 PM.png (788×3 px, 241 KB)
Screen Shot 2022-02-10 at 6.01.48 PM.png (1×804 px, 130 KB)
Screen Shot 2022-02-10 at 6.01.17 PM.png (1×798 px, 114 KB)