Maniphest T299811

"Show all fields" button in template dialog is confusing when all fields are there
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Krinkle
	Jan 21 2022, 11:58 PM

Tags

Referenced Files

	F34926214: Screenshot.png
	Jan 21 2022, 11:58 PM

Subscribers

Description

Given a template that is documented (e.g. one required and one optional parameter).
Given a page where that template is used with all parameters.
Editing that page in VE shows a button "Hide/show all fields". Clicking the button does not do anything, which feels confusing.

Screenshot.png (625×1 px, 46 KB)

To do in WMDE-TechWish-Sprint-2022-02-02:

Disable the button (don't hide it) when all checkboxes are checked, and enable it only when at least one checkbox is unchecked.
When this is implemented, test if there are still edge cases left where clicking the button doesn't do anything.

Details

	Subject	Repo	Branch	Lines +/-
	Disable hide unused widget when all are selected	mediawiki/extensions/VisualEditor	master	+35 -5

Customize query in gerrit

Event Timeline

Krinkle created this task.Jan 21 2022, 11:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 21 2022, 11:58 PM

Krinkle added a project: VisualEditor.Jan 21 2022, 11:59 PM

Lena_WMDE moved this task from Backlog to Ready for story time on the WMDE-Templates-FocusArea board.Feb 2 2022, 8:21 AM

WMDE-Fisch set the point value for this task to 3.Feb 4 2022, 10:17 AM

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-02-02.

thiemowmde updated the task description. (Show Details)Feb 4 2022, 10:29 AM

Lena_WMDE moved this task from Ready for story time to In sprint on the WMDE-Templates-FocusArea board.Feb 4 2022, 10:36 AM

WMDE-Fisch claimed this task.Feb 4 2022, 10:39 AM

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-02-02 board.

Change 759698 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Disable hide unused widget when all are selected

https://gerrit.wikimedia.org/r/759698

gerritbot added a project: Patch-For-Review.Feb 4 2022, 12:30 PM

WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-02-02 board.Feb 4 2022, 12:38 PM

Change 759698 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Disable hide unused widget when all are selected

https://gerrit.wikimedia.org/r/759698

thiemowmde moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-02-02 board.Feb 9 2022, 11:48 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 9 2022, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 9 2022, 12:10 PM

thiemowmde closed this task as Resolved.Feb 22 2022, 9:42 AM

thiemowmde moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-02-02 board.