Page MenuHomePhabricator

Topic subscription notifications no longer taking you to precise location where activity exists
Closed, ResolvedPublic

Description

It appears that clicking a new "group" comment notification from within Echo on desktop no longer takes you to the precise location where that comment exists.

Behavior

  1. Subscribe to a discussion using Topic Subscriptions
  2. Open Echo on desktop by clicking the "📥" icon within the page header
  3. Notice a notification from within Echo that indicates multiple "new replies" have been posted in the discussion you subscribed to in "1."
  4. Click the notification you observed in "3."

Actual

  1. ❗️Arrive at the top of the talk page where the comments you were notified about in "3." were posted. Note: the comments you were notified about in "3." are highlighted in blue.

Expected

  1. ✅Arrive to the talk page where the comments you were notified about in "3." were posted with the page scrolled so that the comment you were being notified about, that is in the highest position on the page, is focused in view . Note: the comments you were notified about in "3." are highlighted in blue.

Event Timeline

matmarex added a subscriber: matmarex.

Caused by rEDTOebd37369ce43: Controller: Document private methods (which accidentally removed a ! character, causing us to not scroll when we should scroll, and vice versa).

Change 756103 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Restore scrolling to comments when clicking a bundled notification

https://gerrit.wikimedia.org/r/756103

Change 756103 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Restore scrolling to comments when clicking a bundled notification

https://gerrit.wikimedia.org/r/756103