| Emufarmers | |
| Mar 10 2011, 10:44 PM |
| F7588: provisional-merge.diff | |
| Nov 21 2014, 11:28 PM |
Special:NewMessages is presently unpaginated; for people who let their messages accumulate into the thousands (don't judge us!), the page will eventually become big enough to choke a browser (and long before that, it will stop being useful).
Version: unspecified
Severity: minor
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T31090 Special:NewMessages should be paginated on WMF | |||
| Resolved | Catrope | T29983 Special:NewMessages should be paginated |
Mine doesn't even render; the page just times out (over 3700 messages).
At least once I eventually got this:
Database error
A database query syntax error has occurred. This may indicate a bug in the software. The last attempted database query was:
(SQL query hidden)
from within function "User::invalidateCache". Database returned error "1205: Lock wait timeout exceeded; try restarting transaction (10.0.6.49)".
Seems to have been done last September on trunk, in r72707 and friends (which is tagged 1.18). Has not been merged for 1.17 or deployment.
This is still blocking me from reading messages on www.mediawiki.org: now up to 4,844 unread messages.
Created attachment 8470
Provisional merge of r72707, r72708, r72807, r72812
Attached a provisional patch that's a direct merge of r72707, r72708, r72807, r72812 from trunk to 1.17wmf1.
This applies cleanly, but doesn't seem to work properly: Special:NewMessages doesn't show any threads for me with the patch on 1.17wmf1, while it's fine on trunk. There might be some other related things it needs that should also be merged.
Note that there's a schema change in this set, adding ums_conversation and adjusting an index on the thread table. May require ops coordination to roll out.
Attached:
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
(In reply to comment #7)
Created attachment 8470 [details]
Provisional merge of r72707, r72708, r72807, r72812Attached a provisional patch that's a direct merge of r72707, r72708, r72807,
r72812 from trunk to 1.17wmf1.This applies cleanly, but doesn't seem to work properly: Special:NewMessages
doesn't show any threads for me with the patch on 1.17wmf1, while it's fine on
trunk. There might be some other related things it needs that should also be
merged.Note that there's a schema change in this set, adding ums_conversation and
adjusting an index on the thread table. May require ops coordination to roll
out.
I believe you'll need to pre-populate the ums_conversation field. The supplied patch file should do this for you.
Attached:
Marking FIXED per Brion's change to the bug summary late April 2011.
Bug 29090 for if and how we would pre-deploy this on WMF (or wait for the deployment of the finished rewrite in 1.18/1.19/1.20)