I have this filter on Incubator https://incubator.wikimedia.org/wiki/Special:AbuseFilter/29 which tries to catch some of the long-term abuser "GRP"'s spam. Unfortunately, he just clicks save 5 times or so in a row and it gets automatically disabled because it hit some magic limit. This needs to be adjusted.
I'm sitting here watching the filter to reactivate it as soon as it gets throttled again. The filter works perfectly (improved just today by Danny B. - thanks!), just gets sabotaged by the throttle...
I have weak permissions to look into the logs. But this is what I can see.
Incubator uses the default config:
'wgAbuseFilterEmergencyDisableThreshold' => [ 'default' => [ 'default' => 0.05 ], ], 'wgAbuseFilterEmergencyDisableCount' => [ 'default' => [ 'default' => 2 ], ], 'wgAbuseFilterEmergencyDisableAge' => [ 'default' => [ 'default' => 86400 ], ],
The meaning is:
Disable potentially dangerous actions (AbuseFilterRestrictions) of a filter if it matches more than X actions, constituting more than Y% (e.g. 0.05 = 5%) of the last Z actions, and the filter has been modified in the last S seconds. X is AbuseFilterEmergencyDisableCount, Y is AbuseFilterEmergencyDisableThreshold, S is AbuseFilterEmergencyDisableAge and Z is a number between 1 and AbuseFilterProfileActionsCap.
See also T210151.
Yes, AFAIK the throttling only disables "dangerous" actions such as block, rangeblock or degroup. Warning and Disallow should keep working.
On Meta, we did increase the emergency thresholds because of a similar incident. See T173633. I guess we can do the same for Incubator.
This is the relevant config for WMF wikis.
Thanks for the patch.
Again edits have gone through the filter (= the LTA could make the edits) where I can't see how they wouldn't match the filter. The filter, again, being throttled.
If a filter which does not do a "dangerous" action is in reality not throttled (i.e. it continues to warn and disallow), should it not say at all then that it is throttled?
@MF-Warburg If the patch looks good to you, could you please get opinions/consensus somewhere on Incubator so I can go forward and ask to deploy this? Also, if you want a particular filter or edit examined in the meanwhile, feel free to reach out to me on IRC and we can try to figure out what's happening.
Thanks for the clarification. Seems like the interface should really be changed. With this clarification, a change of the thresholds shouldn't be necessary. Thanks to MA for creating the patch anyway!