Page MenuHomePhabricator

Normalize categorylinks table
Closed, ResolvedPublic

Description

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
operations/puppetproduction+0 -2
operations/mediawiki-configmaster+0 -9
mediawiki/coremaster+351 -74
mediawiki/coremaster+129 -3
mediawiki/coremaster+3 -2
mediawiki/coremaster+53 -121
mediawiki/extensions/FlaggedRevsmaster+13 -46
mediawiki/coremaster+145 -316
mediawiki/extensions/intersectionmaster+25 -44
mediawiki/extensions/Flowmaster+7 -19
mediawiki/extensions/GoogleNewsSitemapmaster+22 -39
mediawiki/extensions/Collectionmaster+6 -17
mediawiki/extensions/GlobalUsagemaster+6 -19
mediawiki/extensions/CategoryTreemaster+13 -33
mediawiki/extensions/CategoryTreewmf/1.45.0-wmf.16+13 -33
mediawiki/coremaster+14 -1
mediawiki/coremaster+125 -94
mediawiki/coremaster+4 -7
mediawiki/coremaster+400 -16
mediawiki/coremaster+57 -6
mediawiki/coremaster+265 -0
operations/puppetproduction+1 -1
operations/puppetproduction+11 -1
operations/puppetproduction+2 -0
operations/puppetproduction+5 -1
operations/puppetproduction+7 -0
mediawiki/coremaster+70 -0
mediawiki/coremaster+146 -9
mediawiki/coremaster+350 -0
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
ResolvedLadsgroup
ResolvedZabe
ResolvedMarostegui
ResolvedLadsgroup
ResolvedLadsgroup
ResolvedZabe
Resolvedamastilovic
ResolvedBTullis
ResolvedZabe
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORZabe
ResolvedMarostegui
ResolvedMarostegui
DeclinedMarostegui
DeclinedMarostegui
ResolvedZabe
ResolvedPRODUCTION ERRORZabe
ResolvedLadsgroup
ResolvedPRODUCTION ERRORZabe

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change #1181812 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Formally drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1181812

Change #1181812 merged by jenkins-bot:

[mediawiki/core@master] Formally drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1181812

Change #1182120 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/intersection@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1182120

Change #1182123 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CategoryTree@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1182123

Change #1182124 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Collection@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1182124

Change #1182126 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Flow@master] Drop support for categorylinks read new

https://gerrit.wikimedia.org/r/1182126

Change #1182127 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/GlobalUsage@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1182127

Change #1182141 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/GoogleNewsSitemap@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1182141

Change #1182144 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Drop cl_to and cl_collation from categorylinks table

https://gerrit.wikimedia.org/r/1182144

Change #1182155 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Move cl_collation normalization to its own maintenance script

https://gerrit.wikimedia.org/r/1182155

Change #1182222 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Drop categorylinks read old code

https://gerrit.wikimedia.org/r/1182222

Change #1182238 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Only normalize cl_collation once

https://gerrit.wikimedia.org/r/1182238

Change #1182155 abandoned by Zabe:

[mediawiki/core@master] Move cl_collation normalization to its own maintenance script

Reason:

In favor of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1182238

https://gerrit.wikimedia.org/r/1182155

Change #1182238 merged by jenkins-bot:

[mediawiki/core@master] Only normalize cl_collation once

https://gerrit.wikimedia.org/r/1182238

Change #1183269 had a related patch set uploaded (by Ladsgroup; author: Zabe):

[mediawiki/extensions/CategoryTree@wmf/1.45.0-wmf.16] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1183269

Change #1183269 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@wmf/1.45.0-wmf.16] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1183269

Change #1182123 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1182123

Mentioned in SAL (#wikimedia-operations) [2025-09-01T11:03:56Z] <ladsgroup@deploy1003> Started scap sync-world: Backport for [[gerrit:1183632|ParserTestRunner: Update category counts for articles (T365303)]], [[gerrit:1183633|CategoryCacheTest: Update category count]], [[gerrit:1183269|Drop support for categorylinks read old (T299951 T403147 T403337)]]

Mentioned in SAL (#wikimedia-operations) [2025-09-01T11:09:48Z] <ladsgroup@deploy1003> ladsgroup: Backport for [[gerrit:1183632|ParserTestRunner: Update category counts for articles (T365303)]], [[gerrit:1183633|CategoryCacheTest: Update category count]], [[gerrit:1183269|Drop support for categorylinks read old (T299951 T403147 T403337)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-09-01T11:16:24Z] <ladsgroup@deploy1003> Finished scap sync-world: Backport for [[gerrit:1183632|ParserTestRunner: Update category counts for articles (T365303)]], [[gerrit:1183633|CategoryCacheTest: Update category count]], [[gerrit:1183269|Drop support for categorylinks read old (T299951 T403147 T403337)]] (duration: 12m 28s)

Change #1182127 merged by jenkins-bot:

[mediawiki/extensions/GlobalUsage@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1182127

Change #1182126 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1182126

Change #1182124 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1182124

Change #1182141 merged by jenkins-bot:

[mediawiki/extensions/GoogleNewsSitemap@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1182141

Change #1182120 merged by jenkins-bot:

[mediawiki/extensions/intersection@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1182120

Change #1182222 merged by jenkins-bot:

[mediawiki/core@master] Drop categorylinks read old code

https://gerrit.wikimedia.org/r/1182222

Change #1187547 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/FlaggedRevs@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1187547

Change #1187547 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Drop support for categorylinks read old

https://gerrit.wikimedia.org/r/1187547

Change #1187825 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Drop categorylinks migration code

https://gerrit.wikimedia.org/r/1187825

Change #1187825 merged by jenkins-bot:

[mediawiki/core@master] Drop categorylinks migration code

https://gerrit.wikimedia.org/r/1187825

Is this just T402925 and then done, or is there more?

Change #1192505 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Cleanup remainders of categorylinks migration

https://gerrit.wikimedia.org/r/1192505

Change #1192505 merged by jenkins-bot:

[mediawiki/core@master] Cleanup remainders of categorylinks migration

https://gerrit.wikimedia.org/r/1192505

Is this just T402925 and then done, or is there more?

No, besides getting https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1192505 and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1182144 merged, this is done.

Excellent work. Congratulations!

Change #1192645 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] updater: Proper PRIMARY KEY modification

https://gerrit.wikimedia.org/r/1192645

Change #1192867 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop setting CategoryLinksSchemaMigrationStage

https://gerrit.wikimedia.org/r/1192867

Change #1192645 merged by jenkins-bot:

[mediawiki/core@master] updater: Proper PRIMARY KEY modification

https://gerrit.wikimedia.org/r/1192645

Change #1182144 merged by jenkins-bot:

[mediawiki/core@master] Drop cl_to and cl_collation from categorylinks table

https://gerrit.wikimedia.org/r/1182144

Change #1192867 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop setting CategoryLinksSchemaMigrationStage

https://gerrit.wikimedia.org/r/1192867

Mentioned in SAL (#wikimedia-operations) [2025-10-02T21:41:03Z] <zabe@deploy2002> Started scap sync-world: Backport for [[gerrit:1192867|Stop setting CategoryLinksSchemaMigrationStage (T299951)]]

Mentioned in SAL (#wikimedia-operations) [2025-10-02T21:46:54Z] <zabe@deploy2002> zabe: Backport for [[gerrit:1192867|Stop setting CategoryLinksSchemaMigrationStage (T299951)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-10-02T21:53:40Z] <zabe@deploy2002> Finished scap sync-world: Backport for [[gerrit:1192867|Stop setting CategoryLinksSchemaMigrationStage (T299951)]] (duration: 12m 37s)

The BlogPage and MediaUploader extensions have not been migrated and fail on CI due to the drop of categorylinks.cl_to.

The BlogPage and MediaUploader extensions have not been migrated and fail on CI due to the drop of categorylinks.cl_to.

We don't own nor maintain those extensions, they are not deployed to Wikimedia production and I think it's the responsibility of people behind those extension to fix it not us. If we want to for any change in mw check and fix every single extension in gerrit (and beyond), we can't make any impactful change in our infra.

The BlogPage and MediaUploader extensions have not been migrated and fail on CI due to the drop of categorylinks.cl_to.

BlogPage is tracked (T412781) - there's even a master compatible patch, but, it's only merged in the REL1_45 branch for reasons you can see in the master gerrit change.

MediaUploader has been fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaUploader/+/1221300 (which also addresses deprecation calls made to ParserOutput) 🎉

Change #1239484 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/puppet@production] filtered_tables: Drop old categorylinks columns

https://gerrit.wikimedia.org/r/1239484

Change #1239484 merged by Ladsgroup:

[operations/puppet@production] filtered_tables: Drop old categorylinks columns

https://gerrit.wikimedia.org/r/1239484

Cookbook cookbooks.sre.wikireplicas.update-views run by ladsgroup: Started updating wiki replica views

Cookbook cookbooks.sre.wikireplicas.update-views started by ladsgroup executed with errors:

  • an-redacteddb1001.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace --auto-depool --all-databases --table categorylinks'
  • clouddb1017.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace --auto-depool --all-databases --table categorylinks'
  • clouddb1018.eqiad.wmnet (FAIL)
    • Ran Puppet agent
    • The maintain-views run failed, see OUTPUT of 'maintain-views ...' above for details

Cookbook cookbooks.sre.wikireplicas.update-views run by ladsgroup: Started updating wiki replica views

Cookbook cookbooks.sre.wikireplicas.update-views started by ladsgroup executed with errors:

  • an-redacteddb1001.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace --auto-depool --all-databases --table categorylinks'
  • clouddb1017.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace --auto-depool --all-databases --table categorylinks'
  • clouddb1018.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace --auto-depool --all-databases --table categorylinks'
  • clouddb1019.eqiad.wmnet (FAIL)
    • Ran Puppet agent
    • The maintain-views run failed, see OUTPUT of 'maintain-views ...' above for details

Cookbook cookbooks.sre.wikireplicas.update-views run by ladsgroup: Started updating wiki replica views

Cookbook cookbooks.sre.wikireplicas.update-views started by ladsgroup executed with errors:

  • an-redacteddb1001.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace --auto-depool --all-databases --table categorylinks'
  • clouddb1017.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace --auto-depool --all-databases --table categorylinks'
  • clouddb1018.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace --auto-depool --all-databases --table categorylinks'
  • clouddb1019.eqiad.wmnet (FAIL)
    • Ran Puppet agent
    • The maintain-views run failed, see OUTPUT of 'maintain-views ...' above for details

Cookbook cookbooks.sre.wikireplicas.update-views run by ladsgroup: Started updating wiki replica views

Cookbook cookbooks.sre.wikireplicas.update-views started by ladsgroup executed with errors:

  • an-redacteddb1001.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace --auto-depool --all-databases --table categorylinks'
  • clouddb1017.eqiad.wmnet (FAIL)
    • Ran Puppet agent
    • The maintain-views run failed, see OUTPUT of 'maintain-views ...' above for details

In the future, please add "it's finally going away" to tech news at least a week in advance. We already have multiple "what where did it go" on en.wp and I can only assume multiple other wikis were not anticipating an imminent removal.

In the future, please add "it's finally going away" to tech news at least a week in advance. We already have multiple "what where did it go" on en.wp and I can only assume multiple other wikis were not anticipating an imminent removal.

We sent an announcement to cloud-announce@, but I’m happy to also include it in Tech Weeks for broader visibility in the future.