Page MenuHomePhabricator

regression: Difficulty filters cut off at bottom of dialog
Closed, ResolvedPublicBUG REPORT

Description

image.png (1×1 px, 466 KB)

On mobile, this isn't a problem.

When cancelling the dialog from this state, the count shows 0 in the footer.

Event Timeline

@RHo should we make the height of the dialog taller, or keep the current height and allow for scrolling (like we do on mobile)?

kostajh changed the subtype of this task from "Task" to "Bug Report".

I think the issue is that the footer is not part of the initial dialog height calculation since it's shown asynchronously (when there's article count). When the dialog is opened before fetchTasksAndUpdateView resolves, the footer is shown afterwards. This is more consistently reproducible with slow connections (or with network throttle).

In the screen recording here, the first time the dialog is shown, the footer is not present so when the footer is shown, it overlaps. In the subsequent showing, the dialog's height takes into account that of the footer.

Additionally when this occurs, the first count is 5 and the subsequent count shown is 0. This is because the dialog state is backed up when it's shown. However, if the API request to fetch tasks responds after the dialog is shown, the state that's backed up is that prior to the tasks are fetched.

Change 757957 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: Always show footer in FiltersDialog

https://gerrit.wikimedia.org/r/757957

Urbanecm_WMF changed the task status from Open to In Progress.Jan 31 2022, 11:33 AM
kostajh changed the task status from In Progress to Open.Feb 4 2022, 2:18 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 757957 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: Always show footer in FiltersDialog

https://gerrit.wikimedia.org/r/757957

Etonkovidova subscribed.

I've seen the issue happening couple of times but never had reliable steps to introduce. Checked on testswiki wmf.21 - the vertical scrolling is added if a screen height requires it; the footer is fully displayed all the time.