Page MenuHomePhabricator

(Sticky header) use text-overflow: ellipsis; instead of fade out on page title
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

We are currently using a fade to indicate when a page title in the sticky header has been clipped, example (link):

Screen Shot 2022-01-25 at 7.56.29 AM.png (808×2 px, 605 KB)

Instead we should switch to using text-overflow: ellipsis. It is a more clear indication that text has been clipped, and it is provided as a built-in CSS feature which I imagine makes the code more simple. Example:

Screen Shot 2022-01-25 at 7.58.51 AM.png (520×2 px, 352 KB)

Notes

I apologize for the change in design here. Previously we hadn't reached a decision on the design team as to whether or not ellipsis were an internationally recognizable indication of clipped text. We have now agreed that it is acceptable. In the future CSS may even allow for language-specific overrides of how to handle this property.

QA steps

Screen Shot 2022-02-03 at 4.57.07 PM.png (852×2 px, 350 KB)

Details

Related Changes in Gerrit:

Event Timeline

ovasileva triaged this task as Medium priority.Jan 25 2022, 6:19 PM
LGoto set the point value for this task to 2.Jan 25 2022, 6:26 PM
LGoto moved this task from Incoming to Sticky header on the Vector 2022 board.

Change 759583 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Fix page title in sticky header:

https://gerrit.wikimedia.org/r/759583

cjming removed cjming as the assignee of this task.Feb 3 2022, 8:37 PM
cjming updated the task description. (Show Details)
cjming subscribed.

Test wiki created on Patch demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/1c183841bf/w/

Test wiki on Patch demo by CMing (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/1c183841bf/w/

Test wiki created on Patch demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/d990d92b37/w/

Change 759583 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fixes for sticky header:

https://gerrit.wikimedia.org/r/759583

Looks good in production, resolving

Screen Shot 2022-02-14 at 1.18.43 PM.png (658×1 px, 211 KB)

Test wiki on Patch demo by CMing (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d990d92b37/w/