Page MenuHomePhabricator

reimaging swift backends should set swift UID/GID to match filesystems
Closed, ResolvedPublic

Description

Consistency fleet-wise is going to take a while (essentially 'til all the old systems are retired); in the mean time, reimaging should ensure that the swift user owns the files on the swift filesystems.

Event Timeline

Change 757025 had a related patch set uploaded (by MVernon; author: MVernon):

[operations/puppet@production] install_server: swift UID/GID should match filesystems (if present)

https://gerrit.wikimedia.org/r/757025

Change 757025 merged by MVernon:

[operations/puppet@production] install_server: swift UID/GID should match filesystems (if present)

https://gerrit.wikimedia.org/r/757025

Fixed by CR 757025 (hopefully!)

This doesn't work, because while busybox seems to have stat the installer can't find it?!?

Apr 29 10:05:33 log-output: + mktemp -d
Apr 29 10:05:33 log-output: + mp=/tmp/tmp.nfZ6QR
Apr 29 10:05:33 log-output: + '[' -b /dev/sde1 ]
Apr 29 10:05:33 log-output: + mount -t xfs -o ro /dev/sde1 /tmp/tmp.nfZ6QR
Apr 29 10:05:33 kernel: [  308.365106] XFS (sde1): Mounting V5 Filesystem
Apr 29 10:05:34 log-output: + stat -c '%u' /tmp/tmp.nfZ6QR/objects
Apr 29 10:05:34 log-output: /tmp/late_command: line 56: stat: not found
Apr 29 10:05:34 log-output: + swiftuid=
Apr 29 10:05:34 log-output: + swiftuid=
Apr 29 10:05:34 log-output: + stat -c
Apr 29 10:05:34 log-output:  '%g' /tmp/tmp.nfZ6QR/objects
Apr 29 10:05:34 log-output: /tmp/late_command: line 57: stat: not found
Apr 29 10:05:34 log-output: + swiftgid=
Apr 29 10:05:34 log-output: + swiftgid=
Apr 29 10:05:34 log-output: + umount
Apr 29 10:05:34 log-output:  /tmp/tmp.nfZ6QR
Apr 29 10:05:34 log-output: + rmdir /tmp/tmp.nfZ6QR
Apr 29 10:05:34 kernel: [  308.502001] XFS (sde1): Ending clean mount
Apr 29 10:05:34 kernel: [  308.503913] XFS (sde1): Unmounting Filesystem

Change 787717 had a related patch set uploaded (by MVernon; author: MVernon):

[operations/puppet@production] install_server install coreutils so we have stat available

https://gerrit.wikimedia.org/r/787717

Change 787717 merged by MVernon:

[operations/puppet@production] install_server install coreutils so we have stat available

https://gerrit.wikimedia.org/r/787717

Revised version (using coreutils' stat from /target) worked with ms-be2041.

Change 792227 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] P:swift::storage: Use disk_type to identify swift disks

https://gerrit.wikimedia.org/r/792227