Page MenuHomePhabricator
Create Task
Maniphest T300067

Add test coverage of function-orchestrator's utils.js file
Closed, ResolvedPublic
Actions

Description

https://doc.wikimedia.org/cover/abstract-wiki/wikifunctions/function-orchestrator/lcov-report/utils.js.html

  • responseEnvelopeContainsError() - patch
  • responseEnvelopeContainsValue()
  • createSchema()
  • createZObjectKey()
  • isError()
  • isGenericType()
  • isRefOrString()
  • makeBoolean()
  • makeWrappedResultEnvelope()
  • quoteZObject()
  • returnOnFirstError()
  • setMetadataValues()
  • traverseZList()

Details

ProjectBranchLines +/-Subject
mediawiki/services/function-orchestratormaster+72 -8utils.responseEnvelopeContainsError: Add some test coverage
mediawiki/services/function-orchestratormaster+42 -0[WIP] tests: Add test coverage of utils.isFunctionCall()
Customize query in gerrit
ReferenceSource BranchDest BranchAuthorTitle
repos/abstract-wiki/wikifunctions/function-orchestrator!24apine-mock-utilsmainapineIncrease test coverage for utils.js. Also fix a couple of bugs:
Customize query in GitLab

Related Objects

Event Timeline

Jdforrester-WMF created this task.Jan 25 2022, 7:50 PM
gerritbot added a comment.Jan 25 2022, 7:54 PM

Change 757072 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] [WIP] tests: Add test coverage of utils.isFunctionCall()

https://gerrit.wikimedia.org/r/757072

gerritbot added a project: Patch-For-Review.Jan 25 2022, 7:54 PM
DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Feb 8 2022, 5:25 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
Jdforrester-WMF claimed this task.Feb 8 2022, 5:25 PM
gerritbot added a comment.Feb 11 2022, 4:27 PM

Change 757072 abandoned by Jforrester:

[mediawiki/services/function-orchestrator@master] [WIP] tests: Add test coverage of utils.isFunctionCall()

Reason:

isFunctionCall() no longer exists.

https://gerrit.wikimedia.org/r/757072

Jdforrester-WMF removed Jdforrester-WMF as the assignee of this task.Feb 11 2022, 4:27 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:40 PM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:39 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF updated the task description. (Show Details)Dec 2 2022, 9:18 PM
gerritbot added a comment.Dec 2 2022, 9:22 PM

Change 863397 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] utils.responseEnvelopeContainsError: Add some test coverage

https://gerrit.wikimedia.org/r/863397

gerritbot added a project: Patch-For-Review.Dec 2 2022, 9:22 PM
Jdforrester-WMF updated the task description. (Show Details)Dec 2 2022, 9:22 PM
gerritbot added a comment.Dec 6 2022, 7:07 PM

Change 863397 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] utils.responseEnvelopeContainsError: Add some test coverage

https://gerrit.wikimedia.org/r/863397

Jdforrester-WMF mentioned this in rMSFO16e3beb47c10: utils.responseEnvelopeContainsError: Add some test coverage.Dec 6 2022, 7:09 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 6 2022, 7:32 PM
Jdforrester-WMF updated the task description. (Show Details)Dec 6 2022, 11:41 PM
Jdforrester-WMF triaged this task as Low priority.Mar 24 2023, 12:41 AM
CodeReviewBot added a comment.Jun 1 2023, 4:43 PM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/24

Increase test coverage for utils.js. Also fix a couple of bugs:

cmassaro claimed this task.Jun 1 2023, 5:03 PM
CodeReviewBot added a comment.Jun 1 2023, 6:48 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/24

Increase test coverage for utils.js. Also fix a couple of bugs:

Jdforrester-WMF closed this task as Resolved.Jun 1 2023, 7:28 PM
Jdforrester-WMF updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL