Page MenuHomePhabricator

Access the collection button style is broken
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Mh-3110
Jan 25 2022, 8:46 PM
Referenced Files
F35009999: ext1.png
Mar 17 2022, 1:58 PM
F35008618: 1234.png
Mar 16 2022, 11:29 AM
F35008574: button.png
Mar 16 2022, 10:38 AM
F35007283: proxy.png
Mar 15 2022, 5:07 PM
F35007269: image.png
Mar 15 2022, 4:44 PM
F35005461: ss.png
Mar 14 2022, 4:32 PM
F34930627: Capture d’écran 2022-01-25 à 21.42.31.png
Jan 25 2022, 8:46 PM

Description

Steps to reproduce:

  • Login to the WikipediaLibrary
  • Access the users/my_library/ page

What happens?:
On the collection listing page, the style of the button to view a collection is broken. Some part of the label text is not visible because the background color doesn't cover the full button.

Device: This happens only on desktop or PC. Looks good on mobile devices

See attached screenshot:

Capture d’écran 2022-01-25 à 21.42.31.png (1,094×1,156 px, 246 KB)

What should have happened instead?:
The full text of the label should be visible, with the background-color covering all the button.

How to fix?
This need a CSS update. The current width of the button is 50% on desktops/PC. This needs to be fixed to be 100%

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Event Timeline

Thanks for reporting this @Mh-3110!

I noticed you claimed the task, do you plan to work on fixing this issue? Just checking :)

Hi @Samwalton9 yes will work on it. A PR is on the way.
Thanks

Samwalton9-WMF moved this task from Ready to Review on the The-Wikipedia-Library (Kanban) board.

I've left one comment on the GitHub ticket :)

Ankit18gupta subscribed.

Hi @Samwalton9 ,
It looks this task is inactive for quite a long. Can you reassign this to me so that I can fix this issue?
Thanks.

@Samwalton9 Can you please provide me details to understand this - "you'll need to apply to a partner which is set to the PROXY access method, then you select an expiry date and this should display for you."
Also a image is attached for what I am referring to.

ss.png (359×135 px, 5 KB)

To test this case, you need to set a resource object to have the 'Proxy' authorizaton method. Then file an application for it, selecting an expiry date. Navigate to the application ('view my applications') and set it to Approved. Then (after logging out and back in to clear the cache), you should have a new My Library tile for that resource, which has an expiration date.

This will enable to you test whether your solution works when the Extend button is present.

To test this case, you need to set a resource object to have the 'Proxy' authorizaton method. Then file an application for it, selecting an expiry date. Navigate to the application ('view my applications') and set it to Approved. Then (after logging out and back in to clear the cache), you should have a new My Library tile for that resource, which has an expiration date.

This will enable to you test whether your solution works when the Extend button is present.

How to set - "set a resource object to have the 'Proxy' authorizaton method"

To test this case, you need to set a resource object to have the 'Proxy' authorizaton method. Then file an application for it, selecting an expiry date. Navigate to the application ('view my applications') and set it to Approved. Then (after logging out and back in to clear the cache), you should have a new My Library tile for that resource, which has an expiration date.

This will enable to you test whether your solution works when the Extend button is present.

How to set - "set a resource object to have the 'Proxy' authorizaton method"

Navigate to /admin, then click Partners. Select one of them, make sure they have the Status of Available and set the Authorization Method to Proxy:

image.png (362×91 px, 7 KB)

To test this case, you need to set a resource object to have the 'Proxy' authorizaton method. Then file an application for it, selecting an expiry date. Navigate to the application ('view my applications') and set it to Approved. Then (after logging out and back in to clear the cache), you should have a new My Library tile for that resource, which has an expiration date.

This will enable to you test whether your solution works when the Extend button is present.

How to set - "set a resource object to have the 'Proxy' authorizaton method"

Navigate to /admin, then click Partners. Select one of them, make sure they have the Status of Available and set the Authorization Method to Proxy:

image.png (362×91 px, 7 KB)

What to do about this error? (image attached)
Secondly, how to file an application for it?

proxy.png (577×202 px, 16 KB)

Oh you'll need to write a URL in the "Target url:" field for the partner, it can be anything for testing purposes.

To file an application, click the 'Available collections' tab in My Library and find the partner you just configured, then click Apply.

Hi @Samwalton9 ,
Thanks for helping me. I have attached an image, of how the button will look. Please provide feedback. Should I move on filing a PR?

button.png (627×458 px, 29 KB)

Hi @Samwalton9 ,
Thanks for helping me. I have attached an image, of how the button will look. Please provide feedback. Should I move on filing a PR?

button.png (627×458 px, 29 KB)

Thanks, can you show me what it looks like for a tile which doesn't have an expiry?

Hi @Samwalton9 ,
Thanks for helping me. I have attached an image, of how the button will look. Please provide feedback. Should I move on filing a PR?

button.png (627×458 px, 29 KB)

Thanks, can you show me what it looks like for a tile which doesn't have an expiry?

Could you please brief me on the steps? Since it compels me to have minimum of 1 month expiry.

Ah, I forgot which data gets generated. You'll need to set a partner to be the 'Library Bundle' access method (it needs a Target URL again). After relogging this should show up in 'My collections'.

@Samwalton9
I have attached the image below(you could see both). Should I proceed with filing a PR now?

1234.png (847×350 px, 38 KB)

Could you add some padding between the Access Collection and Extend button?

Hi @Samwalton9 ,
Image attached. please confirm ASAP.

ext1.png (457×331 px, 11 KB)

That looks good - please feel free to file a PR!