Page MenuHomePhabricator

InstantCommons/ForeignAPIFile cannot render the audio player on the filepage
Closed, ResolvedPublic

Description

The reason this fails is because audio doesn't have an 'inherent' visual size as a non-visual medium. As such, it returns a 0x0 size for the thumbnailurl when it tries to return the thumbnail for the original on the file description page.
But the foreignapifile class considers any error in fetching the thumburl as a fatal.

In the localfile situation for an image page this is no problem, it fakes a path (0px .jpg) and passes that. But the remote api only return the fileimage thumburl (which it does have btw) if it has a valid width and height of more than 0. (Specifically urlparam)

Event Timeline

Change 757120 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/core@master] Support audio on filepage in InstantCommons

https://gerrit.wikimedia.org/r/757120

Change 757120 merged by jenkins-bot:

[mediawiki/core@master] Support audio on filepage in InstantCommons

https://gerrit.wikimedia.org/r/757120

TheDJ claimed this task.