Page MenuHomePhabricator

Text `[comments]` is not customisable or translateable
Closed, ResolvedPublic

Description

For polls of type range voting (histogram range) with comment, the text [comments] is shown above the text boxes where one can provide comments. This implies that it is customisable per election, but it is not, nor is it translateable through Special:SecurePoll/translate (as other similar fields, like [intro] and [return-text], are).

Screenshot 2022-01-25 at 4.06.37 PM.png (787×1 px, 52 KB)

As suggested by @tstarling here, it may make more sense for this to be a MediaWiki message than one which alters per election.

Event Timeline

Do you want it to be customised per election? It seems like it would make more sense for it to use MediaWiki messages, like the labels in the STV ballot.

Do you want it to be customised per election? It seems like it would make more sense for it to use MediaWiki messages, like the labels in the STV ballot.

Good point. I would agree with that. I'm not sure if there might be an external use case for a custom message on a per-election basis, but it'd for sure be better as a MediaWiki message than a static block of text as it is now.

Change 763396 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/SecurePoll@master] Add optional comment box to the end of the vote form

https://gerrit.wikimedia.org/r/763396

Given the Gerrit commit, I suppose this will be translateable on TranslateWiki - is there anything we need to do to make that happen?

Given the Gerrit commit, I suppose this will be translateable on TranslateWiki - is there anything we need to do to make that happen?

When the messages are merged they are usually live on translatewiki.net within a day or so. Exports will start after translations happen. But as we don't run localisation update, the translations will only end up live on WMF sites after following train.

We *might* be able to get twn to mark them as high priority or something, and potentially do some adhoc localisation update backports if we get the necessary translations.

As of writing, branching happens in about 7 hours - https://wikitech.wikimedia.org/w/index.php?title=Deployments&oldid=1952909#deploycal-item-20220301T0200

Change 763396 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Add optional comment box to the end of the vote form

https://gerrit.wikimedia.org/r/763396

When will this change make the train? A little nervous with the election so close now. Sorry for my angst!

Should be rolling out this week, it's in wmf/1.38.0-wmf.24 so should be everywhere by the end of the week (as long as the train doesn't get held up)

Should be rolling out this week, it's in wmf/1.38.0-wmf.24 so should be everywhere by the end of the week (as long as the train doesn't get held up)

Thank you!

jrbs assigned this task to tstarling.

@tstarling's patch went live with the train and looks great! Thank you!