Page MenuHomePhabricator

Remove "implementation and tester" tab from function definition
Closed, ResolvedPublic

Description

Changing the create function UI by removing the implementations and tests tabs has a few moving parts to it. We need to make the following changes, and there’s an unknown as well

UI changes:

  • Remove both Implementations and Tests tabs from the FE when a user is creating a new function
  • Remove the Write implementation button from the footer and bring Cancel in closer to the Publish button
  • Remove the checkmark icons
  • Change header from Create a function to Define function

TO BE CONFIRMED
Do we keep the Function definition tab or remove it? Keep the function definition tab

  • Case for keeping it: consistent with Edit function UI
  • Case for removing it: it has no function on the page

image.png (1×1 px, 67 KB)

image.png (1×1 px, 68 KB)

Event Timeline

JKieserman changed the task status from Open to In Progress.Jan 26 2022, 5:00 PM
JKieserman claimed this task.

We will keep the 'Function definition' tab

Change 757660 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] additional edits to function editor - remove implementation and next steps

https://gerrit.wikimedia.org/r/757660

Change 757660 abandoned by Jkieserman:

[mediawiki/extensions/WikiLambda@master] additional edits to function editor - remove implementation and next steps

Reason:

https://gerrit.wikimedia.org/r/757660

Change 757515 had a related patch set uploaded (by Jforrester; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] additional edits to function editor - remove implementation and next steps

https://gerrit.wikimedia.org/r/757515