Page MenuHomePhabricator
Create Task
Maniphest T300177

scap overrides for deploy-local using -D parameter fail
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When reimaging restbase1019 for T295375, puppet runs began to fail. This was out of step with my experience of other reimages, which makes me think this was a recent change. Removing the -D log_json:false argument deployed the services as expected, but this might be indicative of other breakage in scap. Currently we use this argument for all puppet-installed scap services so this will probably break other services if new deploys or reimages are undertaken in future.

Output can be seen in this paste with the override failing and then the install succeeding once the parameter is removed.
https://phabricator.wikimedia.org/P19367

Details

SubjectRepoBranchLines +/-
scap deploy: Fix -D option handling (really this time)mediawiki/tools/scapmaster+12 -4
deploy: Don't call dict() on self.arguments.definesmediawiki/tools/scapmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

hnowlan created this task.Jan 26 2022, 6:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2022, 6:12 PM
hnowlan renamed this task from scap overrides appear to be broken to scap overrides for deploy-local using -D parameter fail.Jan 26 2022, 6:14 PM
dancy added a parent task: T300058: Deploy Scap version 4.2.1.Jan 26 2022, 7:23 PM
gerritbot added a comment.Jan 26 2022, 7:30 PM

Change 757510 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[mediawiki/tools/scap@master] deploy: Don't call dict() on self.arguments.defines

https://gerrit.wikimedia.org/r/757510

gerritbot added a project: Patch-For-Review.Jan 26 2022, 7:30 PM
gerritbot added a comment.Jan 26 2022, 7:32 PM

Change 757510 merged by jenkins-bot:

[mediawiki/tools/scap@master] deploy: Don't call dict() on self.arguments.defines

https://gerrit.wikimedia.org/r/757510

dancy changed the task status from Open to In Progress.Jan 26 2022, 7:44 PM
dancy triaged this task as High priority.
dancy mentioned this in T300058: Deploy Scap version 4.2.1.
dancy added a project: Release-Engineering-Team.
dancy set the point value for this task to 1.
dancy set Final Story Points to 1.
Maintenance_bot removed a project: Patch-For-Review.Jan 26 2022, 8:11 PM
dancy closed this task as Resolved.Jan 27 2022, 3:37 PM

This problem should be fixed now.

hnowlan added a comment.Jan 28 2022, 1:12 PM

I think I'm still seeing this in 4.2.1 I'm afraid:

hnowlan@restbase1020:~$ sudo -u deploy-service /usr/bin/scap deploy-local --repo cassandra/twcs -D log_json:False
WARNING:deploy-local:Unhandled error:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/scap/cli.py", line 357, in run
    app._load_config()
  File "/usr/lib/python3/dist-packages/scap/deploy.py", line 119, in _load_config
    overrides.update(self.arguments.defines)
ValueError: dictionary update sequence element #0 has length 14; 2 is required
ERROR:deploy-local:deploy-local failed: <ValueError> dictionary update sequence element #0 has length 14; 2 is required
hnowlan@restbase1020:~$ dpkg -l scap
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version      Architecture Description
+++-==============-============-============-===========================================
ii  scap           4.2.1-1      all          Deployment toolchain for Wikimedia projects
hnowlan mentioned this in T295375: Restbase migration to Buster.Jan 28 2022, 2:50 PM
dancy added a comment.Jan 28 2022, 3:37 PM

Sorry about this @hnowlan I will investigate more deeply.

dancy reopened this task as In Progress.Jan 28 2022, 3:40 PM
gerritbot added a comment.Jan 28 2022, 5:20 PM

Change 757933 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[mediawiki/tools/scap@master] scap deploy: Fix -D option handling (really this time)

https://gerrit.wikimedia.org/r/757933

gerritbot added a project: Patch-For-Review.Jan 28 2022, 5:20 PM
gerritbot added a comment.Jan 28 2022, 5:26 PM

Change 757933 merged by jenkins-bot:

[mediawiki/tools/scap@master] scap deploy: Fix -D option handling (really this time)

https://gerrit.wikimedia.org/r/757933

Maintenance_bot removed a project: Patch-For-Review.Jan 28 2022, 6:10 PM
dancy mentioned this in T300392: Deploy Scap version 4.2.2.Jan 28 2022, 6:25 PM
dancy added a parent task: T300392: Deploy Scap version 4.2.2.
hnowlan added a comment.Jan 31 2022, 3:12 PM

I think the changes have resolved this issue, I provisioned a new host without issue. Thanks very much for the quick fix!

hnowlan closed this task as Resolved.Jan 31 2022, 3:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL